Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Service Bus] Rule supports parameters of sql expressions and properties of cor filter with multiple data types #12580

Merged
merged 22 commits into from
Jul 24, 2020
Merged

[Service Bus] Rule supports parameters of sql expressions and properties of cor filter with multiple data types #12580

merged 22 commits into from
Jul 24, 2020

Conversation

YijunXieMS
Copy link
Contributor

@YijunXieMS YijunXieMS commented Jul 16, 2020 •
edited
Loading

ServiceBus Subscription Rule has dynamic key values at:

  1. CorrelationFilter's properties. It's support in 7.0.0b4 but only "str" value is accepted
  2. SqlFilter's sql expression parameters. sql expression is supported, but parameters are not.
  3. SqlAction's sql expression parameters. sql expression is supported, but parameters are not.

Now they're all supported. Value type can be str, int, boolean, double, datetime, and duration.

@YijunXieMS YijunXieMS added Service Bus Client This issue points to a problem in the data-plane of the library. labels Jul 16, 2020
@YijunXieMS @KieranBrantnerMagee
note on isodate limitations
1b118ba 
Co-authored-by: KieranBrantnerMagee <[email protected]>
@YijunXieMS
Copy link
Contributor Author

YijunXieMS commented Jul 23, 2020 •
edited
Loading

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yunhaoling
yunhaoling previously approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@YijunXieMS YijunXieMS merged commit 0a28356 into Azure:master Jul 24, 2020
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 29, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
44af22f 
…into regenerate_keys

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  Add foundations for eng/common restructure (Azure#12725)
  Sync eng/common directory with azure-sdk-tools repository (Azure#12730)
  fix flaky test (Azure#12721)
  python link verification (Azure#12543)
  [ServiceBus] Remove legacy control client (Azure#12644)
  mirror update from MicrosoftDocs/azure-docs-sdk-python#709 (Azure#12691)
  [Service Bus] Rule supports parameters of sql expressions and properties of cor filter with multiple data types (Azure#12580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KieranBrantnerMagee KieranBrantnerMagee KieranBrantnerMagee approved these changes

@yunhaoling yunhaoling yunhaoling approved these changes

@annatisch annatisch Awaiting requested review from annatisch

@zikalino zikalino Awaiting requested review from zikalino

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YijunXieMS @KieranBrantnerMagee @yunhaoling