-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Bus] Rule supports parameters of sql expressions and properties of cor filter with multiple data types #12580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YijunXieMS
added
Service Bus
Client
This issue points to a problem in the data-plane of the library.
labels
Jul 16, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_management_client_async.py
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_utils.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/aio/management/_utils.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/management/_constants.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/management/_models.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/management/_utils.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/management/_utils.py
Outdated
Show resolved
Hide resolved
sdk/servicebus/azure-servicebus/azure/servicebus/management/_xml_workaround_policy.py
Show resolved
Hide resolved
yunhaoling
reviewed
Jul 21, 2020
yunhaoling
reviewed
Jul 21, 2020
yunhaoling
reviewed
Jul 21, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/management/_management_client.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Jul 21, 2020
sdk/servicebus/azure-servicebus/azure/servicebus/management/_models.py
Outdated
Show resolved
Hide resolved
yunhaoling
reviewed
Jul 21, 2020
yunhaoling
reviewed
Jul 21, 2020
yunhaoling
reviewed
Jul 21, 2020
yunhaoling
reviewed
Jul 21, 2020
yunhaoling
reviewed
Jul 22, 2020
Co-authored-by: KieranBrantnerMagee <[email protected]>
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
previously approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
KieranBrantnerMagee
previously approved these changes
Jul 23, 2020
YijunXieMS
dismissed stale reviews from KieranBrantnerMagee and yunhaoling
via
July 23, 2020 23:23
3d981a1
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
approved these changes
Jul 24, 2020
KieranBrantnerMagee
approved these changes
Jul 24, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jul 29, 2020
…into regenerate_keys * 'master' of https://github.com/Azure/azure-sdk-for-python: Add foundations for eng/common restructure (Azure#12725) Sync eng/common directory with azure-sdk-tools repository (Azure#12730) fix flaky test (Azure#12721) python link verification (Azure#12543) [ServiceBus] Remove legacy control client (Azure#12644) mirror update from MicrosoftDocs/azure-docs-sdk-python#709 (Azure#12691) [Service Bus] Rule supports parameters of sql expressions and properties of cor filter with multiple data types (Azure#12580)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServiceBus Subscription Rule has dynamic key values at:
properties
. It's support in 7.0.0b4 but only "str" value is acceptedNow they're all supported. Value type can be str, int, boolean, double, datetime, and duration.