-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[text analytics] Updates to Healthcare design #16247
Merged
iscai-msft
merged 29 commits into
Azure:master
from
abhahn:abhahn/ta-v3.1-preview.4-healthcare-updates
Feb 5, 2021
Merged
Changes from 26 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
c00140c
Renamed healthcare methods
e69151c
Exposing job metadata on the healthcare polling operation
d005b70
Aligning with other similar work for Analyze
ac9faf0
Fixed merge conflicts
078e875
Regenerated with custom pollers; updated tests and a few other files
c2a09ff
Renamed HealthcareEntityLink -> HealthcareEntityDataSource and also r…
fb37651
Fixed missed renames in __init__.py
f827c6b
Updated links and other things in the readme
864b1b2
Updated samples readme
2649001
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-pytho…
eed2d38
Reverted an unintentional change in analyze_sentiment
429c4ea
Moved cancellation to the poller; fixed some linting issues
ef6c210
Removed an unused model
91ba6a1
PR comments and updated changelog
a78decd
Added related_entities; Fixed merge conflicts
7da7797
Fixed a few issues caused by merge conflicts; made HealthcareEntity h…
0a14704
Fixed a problem with cancellation; updated samples
d952ded
Merge conflicts
82bc4e4
PR comments
03d68a7
PR comments
00c00a5
Fixed bidirectional check; updated/added tests
f2dedef
added a test for async
bae8200
PR comments and fixing test issues
4563059
Fixed a linting issue
f9e5776
PR comments and fixed a test issue
3745666
Fixed cancellation issue
0971671
Another cancellation test fix
7771a70
PR comments
acc58ed
Async syntax issue
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please explain the role of that new parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please talk briefly about the new graph design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you share a link to your changelog? I got up really early this morning to work on this PR and am close to the time where I will be logging off for the day. If you can share an example I will add it here, otherwise it will have to wait.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, JS Changelog: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/textanalytics/ai-text-analytics/CHANGELOG.md#510-beta4-unreleased
here is the snippet:
[Breaking] The healthcare entities returned by beginAnalyzeHealthcare are now organized as a directed graph where the edges represent a certain type of healthcare relationship between the source and target entities. Edges are stored in the relatedEntities property.