Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metricsadvisor] support key rotation for MetricsAdvisorKeyCredential #16276

Merged
merged 5 commits into from
Jan 21, 2021
Merged

[metricsadvisor] support key rotation for MetricsAdvisorKeyCredential #16276

merged 5 commits into from
Jan 21, 2021

Conversation

kristapratico
Copy link
Member

Resolves #14075

@kristapratico kristapratico self-assigned this Jan 21, 2021
xiangyan99
xiangyan99 reviewed Jan 21, 2021
View reviewed changes
Copy link
Member

@xiangyan99 xiangyan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update changelog too. We want to list the new feature. :)

@kristapratico kristapratico merged commit 95b40c2 into Azure:master Jan 21, 2021
@kristapratico kristapratico deleted the rotate-key branch January 21, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya

Assignees

@kristapratico kristapratico

Labels
Cognitive - Metrics Advisor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[metricsadvisor] MetricsAdvisorCredential should support credential rotation
2 participants
@kristapratico @xiangyan99