-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
converge management documentation generation to the same methodology … #16369
Conversation
…in preperation for deleting generate_doc.py
Thanks for taking the step! We can completely remove the |
@sima-zhu yep. That's right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nickzhums, could you check the difference for the document? |
@jsntcy Nope other than that you folks ack that:
👍 |
@nickzhums once you sign off on this, I'll merge it. Waiting to merge till you do 👍 |
approved, thanks! |
Thank you! Not going to merge this today as it does touch code that gets used in release. Next week sometime. Thanks! |
…e#16363)" Revert "converge management documentation generation to the same methodology … (Azure#16369)"
…in preparation for deleting generate_doc.py
Hey @changlong-liu this is out of the blue, but @sima-zhu tagged me on another PR that prompted me to start this process.
When you get a few minutes, can you please take a look at this PR? It has some changes of substance for what you see on github.io, but nothing gamebreaking.
You don't need to worry about getting a direct comparison, I've gotten that done for you already!
For acceptance, please compare the results of a
sphinx
run ofazure-mgmt-storage
.Grab these two artifacts:
And compare them.
Really the main difference is how the ToC is generated.