[text analytics] analyze updates #16372
Conversation
iscai-msft
requested review from
abhahn,
danieljurek,
kristapratico,
mitchdenny,
scbedd and
weshaggard
as code owners
ghost
added
the
| - Extract key phrases: [sample_extract_key_phrases.py][extract_key_phrases_sample] ([async version][extract_key_phrases_sample_async]) | ||
| - Detect language: [sample_detect_language.py][detect_language_sample] ([async version][detect_language_sample_async]) | ||
| - Healthcare Analysis: [sample_analyze_healthcare.py][analyze_healthcare_sample] ([async version][analyze_healthcare_sample_async]) | ||
| - Batch Analysis: [sample_anayze.py][analyze_sample] ([async version][analyze_sample_async]) |
There was a problem hiding this comment.
Typo in the filename (sample_anayze.py -> sample analyze.py)
| ~azure.ai.textanalytics.KeyPhraseExtractionTask, ~azure.ai.textanalytics.SentimentAnalysisTask]] | ||
| :type tasks: list[Union[~azure.ai.textanalytics.EntitiesRecognitionAction, | ||
| ~azure.ai.textanalytics.PiiEntitiesRecognitionAction, ~azure.ai.textanalytics.EntityLinkingTask, | ||
| ~azure.ai.textanalytics.KeyPhraseExtractionAction, ~azure.ai.textanalytics.SentimentAnalysisTask]] |
There was a problem hiding this comment.
I think maybe this must've gotten left over from when we previously had planned to release Sentiment for v3.1-preview.3, so we should probably remove it for now.
| ~azure.ai.textanalytics.KeyPhraseExtractionTask, ~azure.ai.textanalytics.SentimentAnalysisTask]] | ||
| :type tasks: list[Union[~azure.ai.textanalytics.EntitiesRecognitionAction, | ||
| ~azure.ai.textanalytics.PiiEntitiesRecognitionAction, ~azure.ai.textanalytics.EntityLinkingTask, | ||
| ~azure.ai.textanalytics.KeyPhraseExtractionAction, ~azure.ai.textanalytics.SentimentAnalysisTask]] |
There was a problem hiding this comment.
Same as a previous comment for the sync client.
| @@ -707,9 +707,9 @@ def begin_analyze( # type: ignore | |||
| list[dict[str, str]] | |||
| :param tasks: A list of tasks to include in the analysis. Each task object encapsulates the parameters | |||
There was a problem hiding this comment.
Should we also rename this to actions?
There was a problem hiding this comment.
Also, below in the body of the method I think we will need to group the tasks by type in order to construct the JobManifest object. For some reason github won't let me add a comment directly on it, so check line 750.
| @@ -709,9 +709,9 @@ async def begin_analyze( # type: ignore | |||
| list[dict[str, str]] | |||
| :param tasks: A list of tasks to include in the analysis. Each task object encapsulates the parameters | |||
There was a problem hiding this comment.
Same as another comment for the sync client.
| entities_recognition_tasks=[EntitiesRecognitionTask()], | ||
| pii_entities_recognition_tasks=[PiiEntitiesRecognitionTask()], | ||
| key_phrase_extraction_tasks=[KeyPhraseExtractionTask()] | ||
| entities_recognition_tasks=[EntitiesRecognitionAction()], |
There was a problem hiding this comment.
I think these were consolidated into a union type with name tasks above.
| entities_recognition_tasks=[EntitiesRecognitionTask()], | ||
| pii_entities_recognition_tasks=[PiiEntitiesRecognitionTask()], | ||
| key_phrase_extraction_tasks=[KeyPhraseExtractionTask()] | ||
| entities_recognition_tasks=[EntitiesRecognitionAction()], |
There was a problem hiding this comment.
Same comment as the other sample.
|
closing because there were a bunch of formatting changes that my editor made. easier to start from scratch @abhahn thanks for starting to review! |
fixes #16120