[text analytics] analyze changes #16418

iscai-msft · 2021-01-29T01:38:47Z

check-enforcer · 2021-02-02T04:28:01Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

…e-sdk-for-python into analyze_redesign * 'analyze_redesign' of https://github.com/iscai-msft/azure-sdk-for-python: fix async tests

…into analyze_redesign * 'master' of https://github.com/Azure/azure-sdk-for-python: (35 commits) Sync eng/common directory with azure-sdk-tools for PR 1353 (Azure#16465) Normalize the package name for Doc.Ms readme (Azure#16401) fix changelog and version (Azure#16445) we should always run integration to publish from our artifacts. if the build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down (Azure#15058) Fix DateTime bug (Azure#16456) Resolve Regression Failures (Azure#16455) [text analytics] Expose 'string_index_type' parameter in all service client methods where applicable (Azure#16412) adding devtools to the appconfig dev_reqs to solve python core issue (Azure#16381) Copy job matrix functionality (Azure#16450) Add APIView KV variable group to prepare pipelines bot (Azure#16451) [Datalake] Added support for PurePosixPath (Azure#16400) Regenerate baseline because last one break. (Azure#16415) adding step to test for crlf line endings (Azure#16398) [Datalake] Removed list_paths manual paging and deserialization (Azure#16309) Sync eng/common directory with azure-sdk-tools for PR 1351 (Azure#16448) Update auto_codegen.py (Azure#16443) First release purview (Azure#16440) 1ES pools update for release pipeline. (Azure#16419) Add Cloud environment for Teams user (Azure#16359) Sync eng/common directory with azure-sdk-tools for PR 1345 (Azure#16404) ...

iscai-msft · 2021-02-02T05:38:14Z

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py

+    RECOGNIZE_PII_ENTITIES = "recognize_pii_entities"  #: PII Entities Recognition action.
+    EXTRACT_KEY_PHRASES = "extract_key_phrases"  #: Key Phrase Extraction action.
+
+class AnalyzeBatchActionsResult(DictMixin):


this is the result object we return to users. begin_analyze_batch_actions returns a list of AnalyzeBatchActionsResult

iscai-msft · 2021-02-02T05:39:21Z

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_response_handlers.py


-def analyze_extract_page_data(doc_id_order, obj, response_headers, analyze_job_state):
-    return analyze_job_state.next_link, [analyze_result(doc_id_order, obj, response_headers, analyze_job_state.tasks)]
+def get_iter_items(doc_id_order, task_order, response_headers, analyze_job_state):


basically, I pass in the order for the different action results users inputted. Then, use that to ensure the output order of task results is in the same result as input

will this work if the user sent more of the same action? i.e. 2 piientities actions with different arguments?

iscai-msft · 2021-02-02T05:40:38Z

sdk/textanalytics/azure-ai-textanalytics/tests/test_analyze_async.py

@@ -172,243 +164,19 @@ async def test_all_successful_passing_dict_pii_entities_task(self, client):
                    self.assertIsNotNone(entity.offset)
                    self.assertIsNotNone(entity.confidence_score)

-    @pytest.mark.playback_test_only
-    @GlobalTextAnalyticsAccountPreparer()


you'll notice some tests are deleted. This is because we have quite a few redundant tests, and since analyze tests take so long, I wanted to remove the redundant ones to make room for incoming tests

iscai-msft · 2021-02-02T19:43:01Z

/check-enforcer override

sdk/textanalytics/azure-ai-textanalytics/README.md

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_async_lro.py

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_response_handlers.py

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_text_analytics_client.py

...tanalytics/azure-ai-textanalytics/azure/ai/textanalytics/aio/_text_analytics_client_async.py

sdk/textanalytics/azure-ai-textanalytics/samples/async_samples/sample_analyze_async.py

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py

maririos · 2021-02-02T22:17:50Z

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_response_handlers.py


-def analyze_extract_page_data(doc_id_order, obj, response_headers, analyze_job_state):
-    return analyze_job_state.next_link, [analyze_result(doc_id_order, obj, response_headers, analyze_job_state.tasks)]
+def get_iter_items(doc_id_order, task_order, response_headers, analyze_job_state):


will this work if the user sent more of the same action? i.e. 2 piientities actions with different arguments?

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_text_analytics_client.py

maririos · 2021-02-02T22:19:43Z

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_text_analytics_client.py

+        :param actions: A heterogeneous list of actions to perform on the inputted documents.
+            Each task object encapsulates the parameters used for the particular task type.
+            The outputted action results will be in the same order you inputted your actions.
+            Can not put duplicate actions into list.


maybe clarify that actions with the same parameters? so like actions need to be unique?

ok, can do, thanks @maririos!

sdk/textanalytics/azure-ai-textanalytics/samples/sample_analyze.py

sdk/textanalytics/azure-ai-textanalytics/tests/test_analyze.py

abhahn · 2021-02-03T17:48:22Z

Can you also make sure that string_index_type is added as a parameter for the action types corresponding to the sync endpoints that also support it?

iscai-msft · 2021-02-03T17:58:48Z

yep @abhahn it's there. thanks!

…into analyze_redesign * 'master' of https://github.com/Azure/azure-sdk-for-python: (32 commits) Adopt new MSAL auth code flow API (Azure#16449) [formrecognizer] use ARM template for tests (Azure#16432) T2 kusto 2021 02 04 (Azure#16527) T2 applicationinsights 2021 02 04 (Azure#16525) Sync eng/common directory with azure-sdk-tools for PR 1366 (Azure#16506) [Python] python track2 new pipeline fix (Azure#16494) Added package properties SDKType and NewSDK (Azure#16476) bump six dependencies in some libraries (Azure#16496) call on_error if timeout in flush (Azure#16485) Sync eng/common directory with azure-sdk-tools for PR 1365 (Azure#16505) Fix min dependency tests - update azure core (Azure#16504) Sync eng/common directory with azure-sdk-tools for PR 1364 (Azure#16503) Ma arch feedback (Azure#16502) Adding a new limitation to the README file. (Azure#16475) [Blob][Datalake] STG76 Preview (Azure#16349) append code coverage over each other (Azure#16202) Arch preview feedback (Azure#16441) Support CAE in azure-identity (Azure#16323) [EventHubs] Support for Custom endpoint adddress and custom certificate (Azure#16295) [Communication] - Phone Number Management - Added support for AAD auth (Azure#16075) ...

kristapratico · 2021-02-04T22:39:57Z

sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py

+
+    def __repr__(self):
+        return "AnalyzeBatchActionsError(error={}, is_error={}".format(
+            self.error, self.is_error


Suggested change

self.error, self.is_error

repr(self.error), self.is_error

…into add_analyze_readme * 'master' of https://github.com/Azure/azure-sdk-for-python: [text analytics] analyze changes (Azure#16418) [Core] Added enum meta class (Azure#16316) Adding missing supported fields to invoice sample (Azure#16547) Update EventHub ci.yml to skip unsupported pypy3 (Azure#16545) patching the publishing of artifacts only on successful run (Azure#16539) need to bump msrest up one (Azure#16544) [EventHub&ServiceBUs] Update readme pointing to uamqp installation guidance (added alpine installation) (Azure#16515) add dotenv as a dep for azure-sdk-tools (Azure#16532) skip prebuilt from_url tests for now (Azure#16534) Latest/Minimum filter retrieved packages by pyVersion compatibility (Azure#16510) CertificateCredential accepts certs as bytes (Azure#16410)

…into expose_length * 'master' of https://github.com/Azure/azure-sdk-for-python: [textanalytics] add :keyword: to docstrings for TextDocumentInput and DetectLanguageInput (Azure#16542) [SB] combine conn str parser logic in base handler and _common (Azure#16464) [text analytics] add analyze readme bullet point (Azure#16552) resolve issues with failing search documents on mindependency checks (Azure#16553) [text analytics] analyze changes (Azure#16418) [Core] Added enum meta class (Azure#16316) Adding missing supported fields to invoice sample (Azure#16547) Update EventHub ci.yml to skip unsupported pypy3 (Azure#16545) patching the publishing of artifacts only on successful run (Azure#16539) need to bump msrest up one (Azure#16544) [EventHub&ServiceBUs] Update readme pointing to uamqp installation guidance (added alpine installation) (Azure#16515) add dotenv as a dep for azure-sdk-tools (Azure#16532) skip prebuilt from_url tests for now (Azure#16534) Latest/Minimum filter retrieved packages by pyVersion compatibility (Azure#16510) CertificateCredential accepts certs as bytes (Azure#16410)

…into new_polling * 'master' of https://github.com/Azure/azure-sdk-for-python: (250 commits) Converting to pure unit tests (Azure#16499) Fix replace keys for nested json (Azure#16557) update release date (Azure#16543) Feature/communication chat preview3 new model (Azure#16561) [text analytics] Exposed the length property in classes impacted by `string_index_type` (Azure#16538) [textanalytics] add :keyword: to docstrings for TextDocumentInput and DetectLanguageInput (Azure#16542) [SB] combine conn str parser logic in base handler and _common (Azure#16464) [text analytics] add analyze readme bullet point (Azure#16552) resolve issues with failing search documents on mindependency checks (Azure#16553) [text analytics] analyze changes (Azure#16418) [Core] Added enum meta class (Azure#16316) Adding missing supported fields to invoice sample (Azure#16547) Update EventHub ci.yml to skip unsupported pypy3 (Azure#16545) patching the publishing of artifacts only on successful run (Azure#16539) need to bump msrest up one (Azure#16544) [EventHub&ServiceBUs] Update readme pointing to uamqp installation guidance (added alpine installation) (Azure#16515) add dotenv as a dep for azure-sdk-tools (Azure#16532) skip prebuilt from_url tests for now (Azure#16534) Latest/Minimum filter retrieved packages by pyVersion compatibility (Azure#16510) CertificateCredential accepts certs as bytes (Azure#16410) ...

Cognitive Services Resource Provider API Version 2021-10-01 (Azure#16418) * Adds base for updating Microsoft.CognitiveServices from version stable/2021-04-30 to version 2021-10-01 * Updates readme * Updates API version in new specs and examples * Changes for 2021-10-01 * Use 201 instead of 202 for Put, Add x-ms-pageable for List. * address comments

* CodeGen from PR 16418 in Azure/azure-rest-api-specs Cognitive Services Resource Provider API Version 2021-10-01 (#16418) * Adds base for updating Microsoft.CognitiveServices from version stable/2021-04-30 to version 2021-10-01 * Updates readme * Updates API version in new specs and examples * Changes for 2021-10-01 * Use 201 instead of 202 for Put, Add x-ms-pageable for List. * address comments * version,CHANGELOG * Update CHANGELOG.md Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> Co-authored-by: Jiefeng Chen <[email protected]>

begin_analyze -> begin_analyze_batch_actions

9252158

ghost added the Cognitive - Text Analytics label Jan 29, 2021

iscai-msft changed the title ~~begin_analyze -> begin_analyze_batch_actions~~ [text analytics] begin_analyze -> begin_analyze_batch_actions Jan 29, 2021

iscai-msft added 11 commits January 28, 2021 20:57

rename task classes (i.e. EntitiesRecognitionTask) to action

2d49745

return results directly on the AnalyzeBatchActionsResult

a834254

rename parameters

092d47b

switch mentions to task to action

b087a57

change input of actions to list, return actions same order as input

3064965

add initial code and test for poller metadata

3274fd8

fix multi page case

510c97b

regen with custom pollers and polling methods

50f1a28

fix pollers and callbacks

09d9135

clean up sync tests

a8a68f8

fix async tests

806a8e5

iscai-msft added 6 commits February 1, 2021 23:53

fix async tests and generated code

ff538ab

Merge branch 'analyze_redesign' of https://github.com/iscai-msft/azur…

7e4cc1e

…e-sdk-for-python into analyze_redesign * 'analyze_redesign' of https://github.com/iscai-msft/azure-sdk-for-python: fix async tests

fix healthcare tests

4fd6637

pylint and mypy

3885590

update samples

5707d8e

iscai-msft marked this pull request as ready for review February 2, 2021 05:35

iscai-msft requested review from abhahn, danieljurek, kristapratico, mitchdenny, scbedd and weshaggard as code owners February 2, 2021 05:35

revert eng tools change

a21646b

iscai-msft removed the request for review from mitchdenny February 2, 2021 05:36

iscai-msft commented Feb 2, 2021

View reviewed changes

iscai-msft added 2 commits February 2, 2021 10:10

remove erroneous async test in sync tests

18602d3

fix domain filter naming and remove await in test

8ed20e1

kristapratico reviewed Feb 2, 2021

View reviewed changes

sdk/textanalytics/azure-ai-textanalytics/README.md Outdated Show resolved Hide resolved

kristapratico reviewed Feb 2, 2021

View reviewed changes

maririos reviewed Feb 2, 2021

View reviewed changes

iscai-msft added 2 commits February 3, 2021 11:13

rename sample_analyze -> sample_analyze_batch_actions

f4a4253

task docstring -> action

8866ba4

status and others added 6 commits February 3, 2021 18:06

address krista's comments

ed075f4

remove playback test only headers

c1f7bdc

add support for heterogeneous list of good and bad responses

20eee41

fix phi

04fff3a

fix sync sample, fix typo in name

e97eb9e

kristapratico reviewed Feb 4, 2021

View reviewed changes

fix repr

54cc95b

kristapratico approved these changes Feb 4, 2021

View reviewed changes

maririos approved these changes Feb 4, 2021

View reviewed changes

iscai-msft merged commit cc00300 into Azure:master Feb 4, 2021

iscai-msft deleted the analyze_redesign branch February 4, 2021 23:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[text analytics] analyze changes #16418

[text analytics] analyze changes #16418

iscai-msft commented Jan 29, 2021

check-enforcer bot commented Feb 2, 2021

iscai-msft Feb 2, 2021

iscai-msft Feb 2, 2021

maririos Feb 2, 2021

iscai-msft Feb 2, 2021

iscai-msft commented Feb 2, 2021

maririos Feb 2, 2021

maririos Feb 2, 2021

iscai-msft Feb 3, 2021

abhahn commented Feb 3, 2021

iscai-msft commented Feb 3, 2021

kristapratico Feb 4, 2021

[text analytics] analyze changes #16418

[text analytics] analyze changes #16418

Conversation

iscai-msft commented Jan 29, 2021

check-enforcer bot commented Feb 2, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iscai-msft commented Feb 2, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhahn commented Feb 3, 2021

iscai-msft commented Feb 3, 2021

Choose a reason for hiding this comment