Initial commit for farmbeats service. #17337

agniveshadhikari · 2021-03-15T08:52:10Z

Adding initial python thin client (convenience layer) code for Azure Farmbeats.

This is implemented as a thin layer on top of autorest generated client, primarily for:

serving as the base layer for the data science specific SDK
having common set of higher level functionality on top of what is provided by the SDK, things like:
- bulk operations (create, queue jobs)
- cascade operations on the farm hierarchy
- perf gains for parallel ops (download of large geospatial files)
and finally, making it super easy to authenticate to your farmbeats instance (creating the client is a one liner)

WIP. Need to figure out test framework, and any other blockers for this PR.

Cleaner hierarchy. Fixed job wait util bug.

check-enforcer · 2021-03-15T08:57:30Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

agniveshadhikari · 2021-03-15T11:03:58Z

/azp run prepare-pipelines

azure-pipelines · 2021-03-15T11:04:03Z

Commenter does not have sufficient privileges for PR 17337 in repo Azure/azure-sdk-for-python

priyankajayaswal1 · 2021-03-15T12:08:41Z

/azp run prepare-pipelines

azure-pipelines · 2021-03-15T12:08:46Z

Commenter does not have sufficient privileges for PR 17337 in repo Azure/azure-sdk-for-python

agniveshadhikari · 2021-03-16T04:22:08Z

/azp run prepare-pipelines

azure-pipelines · 2021-03-16T04:22:17Z

Azure Pipelines successfully started running 1 pipeline(s).

agniveshadhikari · 2021-03-16T05:22:59Z

/azp run python - farmbeats - ci

azure-pipelines · 2021-03-16T05:23:13Z

Azure Pipelines successfully started running 1 pipeline(s).

tjprescott · 2021-03-19T17:35:23Z

This is the contribution guide for Python: https://github.com/Azure/azure-sdk-for-python/blob/master/CONTRIBUTING.md
I would recommend you start cleaning up the CI failures by fixing your README files.

Other minor bugfixes and adding models to public api

johanste · 2021-03-24T06:16:09Z

sdk/farmbeats/azure-farmbeats/azure/farmbeats/apigroupclients/boundaryclient.py

+            boundary,
+        )
+
+    def get_all(


This methods precludes the ability to support server driven paging. We return ItemPaged instances explicitly to not paint ourselves into that corner.

Only keeping autogen code, with slight modifications.

lmazuel · 2021-05-06T18:32:23Z

sdk/farmbeats/azure-farmbeats-ds/README.md

@@ -0,0 +1,80 @@
+# Azure Farnbeats API DS client library for Python


This file should not be here

lmazuel · 2021-05-06T18:32:56Z

sdk/farmbeats/azure-farmbeats/azure/farmbeats/_configuration.py

+
+    from azure.core.credentials import TokenCredential
+
+VERSION = "unknown"


Package needs to be generate with --package-version=1.0.0b1

lmazuel · 2021-05-06T18:33:34Z

sdk/farmbeats/azure-farmbeats/azure/farmbeats/_configuration.py

+
+        self.credential = credential
+        self.api_version = "2021-03-31-preview"
+        self.credential_scopes = kwargs.pop('credential_scopes', [])


This code needs to be generate with --credential-scope with your AAD scope

autorest --python \ --input-file=swagger.json \ --namespace=azure.farmbeats \ --add-credential \ --output-folder=. \ --title=FarmBeatsClient \ --credential-scope="https://farmbeats-dogfood.azure.net/.default" \ --package-version=1.0.0b1

Tried generating with this. Didn't change this line.

…ke endpoints change.

ramya-rao-a · 2021-05-17T17:04:23Z

Closing this PR in favor of #18713 which is now merged.
Thanks @iscai-msft

@agniveshadhikari, Please make further changes in https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/agrifood/azure-agrifood-farming as needed

agniveshadhikari added 4 commits March 11, 2021 09:35

Initial commit for farmbeats client

5fe6592

Added placeholder readme for azure-farmbeats-ds

3ee382b

Updated swagger, autogen code.

486f9a6

Cleaner hierarchy. Fixed job wait util bug.

restructuring

b3dfdd6

agniveshadhikari requested review from lmazuel and mayurid as code owners March 15, 2021 08:52

Add ci.yml

7145caf

agniveshadhikari requested a review from mitchdenny as a code owner March 15, 2021 11:00

Adding readmes, should fix readme validation issue

7c9d862

agniveshadhikari added 3 commits March 21, 2021 16:04

Bumping a header to h2 to hopefully resolve readme check

feaba8b

Deleting top level readme

732780c

Specifying dep versions in setup.py

777a82a

Other minor bugfixes and adding models to public api

johanste reviewed Mar 24, 2021

View reviewed changes

agniveshadhikari added 2 commits March 30, 2021 02:00

Removing wrapper

e76be9a

Only keeping autogen code, with slight modifications.

LROs should be sorted now

8ac675f

agniveshadhikari mentioned this pull request Mar 30, 2021

Board Review: Introducing FarmBeatsClient Azure/azure-sdk#2327

Closed

agniveshadhikari added 4 commits March 30, 2021 19:48

autorest level rename of client

8d74a58

March Swagger updates (not final)

f5a094e

Intermediate checking, LROs probably work

b0994d5

Manually updated swagger

65d7b0f

agniveshadhikari added 2 commits April 22, 2021 15:55

Adding msrest to deps for package

b3f9b3e

Updates, added an example script for now.

ef1f724

lmazuel reviewed May 6, 2021

View reviewed changes

agniveshadhikari added 6 commits May 10, 2021 16:59

Adding a helper script to wrap the generation command

1491922

deleting the ds dir

4ad9af5

Added final version info to setup

e41f714

Generated client form latest swagger. This breaks base url. Yet to ma…

0c205ae

…ke endpoints change.

Added default scope

95cf84d

Adding back baseurl manually

b344a8a

ramya-rao-a closed this May 17, 2021

agniveshadhikari deleted the farmbeats branch June 9, 2021 09:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial commit for farmbeats service. #17337

Initial commit for farmbeats service. #17337

agniveshadhikari commented Mar 15, 2021 •

edited

Loading

check-enforcer bot commented Mar 15, 2021

agniveshadhikari commented Mar 15, 2021

azure-pipelines bot commented Mar 15, 2021

priyankajayaswal1 commented Mar 15, 2021

azure-pipelines bot commented Mar 15, 2021

agniveshadhikari commented Mar 16, 2021

azure-pipelines bot commented Mar 16, 2021

agniveshadhikari commented Mar 16, 2021

azure-pipelines bot commented Mar 16, 2021

tjprescott commented Mar 19, 2021

johanste Mar 24, 2021

lmazuel May 6, 2021

lmazuel May 6, 2021

lmazuel May 6, 2021

agniveshadhikari May 10, 2021

ramya-rao-a commented May 17, 2021

		@@ -0,0 +1,80 @@
		# Azure Farnbeats API DS client library for Python


		from azure.core.credentials import TokenCredential

		VERSION = "unknown"

Initial commit for farmbeats service. #17337

Initial commit for farmbeats service. #17337

Conversation

agniveshadhikari commented Mar 15, 2021 • edited Loading

check-enforcer bot commented Mar 15, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

agniveshadhikari commented Mar 15, 2021

azure-pipelines bot commented Mar 15, 2021

priyankajayaswal1 commented Mar 15, 2021

azure-pipelines bot commented Mar 15, 2021

agniveshadhikari commented Mar 16, 2021

azure-pipelines bot commented Mar 16, 2021

agniveshadhikari commented Mar 16, 2021

azure-pipelines bot commented Mar 16, 2021

tjprescott commented Mar 19, 2021

johanste Mar 24, 2021

Choose a reason for hiding this comment

lmazuel May 6, 2021

Choose a reason for hiding this comment

lmazuel May 6, 2021

Choose a reason for hiding this comment

lmazuel May 6, 2021

Choose a reason for hiding this comment

agniveshadhikari May 10, 2021

Choose a reason for hiding this comment

ramya-rao-a commented May 17, 2021

agniveshadhikari commented Mar 15, 2021 •

edited

Loading