Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tables] Removed TableEntity attribute wrapper #18489

Merged
merged 9 commits into from
May 5, 2021
Merged

[Tables] Removed TableEntity attribute wrapper #18489

merged 9 commits into from
May 5, 2021

Conversation

annatisch
Copy link
Member

Fixes issue #18442

@annatisch
Copy link
Member Author

/azp run python - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@check-enforcer
Copy link

check-enforcer bot commented May 4, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@annatisch
Copy link
Member Author

/azp run python - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@annatisch annatisch marked this pull request as ready for review May 4, 2021 20:33
seankane-msft
seankane-msft approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@seankane-msft seankane-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question, one nit. LGTM

sdk/tables/azure-data-tables/azure/data/tables/_base_client.py
Comment on lines +375 to +376
# if "sharedaccesssignature" in conn_settings:
# credential = AzureSasCredential(conn_settings['sharedaccesssignature'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this wrapper?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm somewhat undecided....
I've left it as a TODO for me to revisit before GA.

sdk/tables/azure-data-tables/tests/test_table.py Outdated Show resolved Hide resolved
@annatisch annatisch linked an issue May 5, 2021 that may be closed by this pull request
[Tables] Remove attribute support from TableEntity #18442
Closed
@annatisch annatisch merged commit 59ecfd8 into Azure:master May 5, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 5, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
024c000 
…into azure_purview_catalog

* 'master' of https://github.com/Azure/azure-sdk-for-python: (109 commits)
  [Tables] Adds support for AzureNamedKeyCredential (Azure#18456)
  [Tables] delete_entity takes an entity instead of row and partition key (Azure#18269)
  [Tables] Removed TableEntity attribute wrapper (Azure#18489)
  [EventHub&ServiceBus] Bump uAMQP dependency (Azure#17942)
  [ServiceBus] add keyword override support to update_ methods in mgmt module (Azure#18210)
  Add compatibility switch to disable CAE (Azure#18148)
  Service Bus Named Key Credential (Azure#18471)
  Change to use dynamic resource connection string for chat tests and identity samples (Azure#18502)
  Increase dependency (Azure#18500)
  show detailed error (Azure#18229)
  prerelease (Azure#18507)
  [Container Registry] addressing issues (Azure#18486)
  update per_call_policies & per_retry_policies (Azure#18406)
  Eh named key (Azure#18292)
  [Tables] Updating EntityProperty (Azure#18177)
  [Service Bus] fix async auth test (Azure#18499)
  [communication] Live Testing - Introduce CloudConfig into test.yml  (Azure#18469)
  Release azure-servicefabric 8.0 (Azure#18488)
  [Communication]: Updated test_search_available_phone_numbers_with_invalid_country_code async test to be consistent with sync test (Azure#18466)
  [Container Registry] DeleteRepositoryResult Changed (Azure#18443)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 6, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
3dc1198 
…into azure_purview_scanning

* 'master' of https://github.com/Azure/azure-sdk-for-python: (550 commits)
  del useless files (Azure#18528)
  delete existing useless files for trafficmanager (Azure#18525)
  Define new replacer to replace keys in recording (Azure#18294)
  [purview] add purview nspkg to ci (Azure#18523)
  ignore analysis for swagger readmes (Azure#18520)
  [purview] add azure-purview-nspkg (Azure#18518)
  [AppConfiguration] Appconfig consistency (Azure#18493)
  [Container Registry] Improved samples (Azure#18263)
  [Container Registry] renamings (Azure#18492)
  [ServiceBus] internal code rename and sample readme update (Azure#18516)
  [EventHub] update link in sample readme (Azure#18517)
  Post Process Event Names Script (Azure#18419)
  [Tables] use etag from entity if match condition is given (Azure#18271)
  adding operation-location to headers that are scrubbed (Azure#18514)
  [Tables] Adds support for AzureNamedKeyCredential (Azure#18456)
  [Tables] delete_entity takes an entity instead of row and partition key (Azure#18269)
  [Tables] Removed TableEntity attribute wrapper (Azure#18489)
  [EventHub&ServiceBus] Bump uAMQP dependency (Azure#17942)
  [ServiceBus] add keyword override support to update_ methods in mgmt module (Azure#18210)
  Add compatibility switch to disable CAE (Azure#18148)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seankane-msft seankane-msft seankane-msft approved these changes

Assignees
No one assigned
Labels
Tables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tables] Remove attribute support from TableEntity
2 participants
@annatisch @seankane-msft