Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename to AZURE_PHONE_NUMBER #18760

Merged
merged 1 commit into from
May 14, 2021
Merged

Rename to AZURE_PHONE_NUMBER #18760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...mmunication/azure-communication-phonenumbers/samples/get_purchased_phone_number_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
Set the environment variables with your own values before running the sample:
1) COMMUNICATION_SAMPLES_CONNECTION_STRING - The connection string including your endpoint and
access key of your Azure Communication Service
2) AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER - The phone number you want to get its information
2) AZURE_PHONE_NUMBER - The phone number you want to get its information
"""

import os
Expand All @@ -24,7 +24,7 @@
)

connection_str = os.getenv('COMMUNICATION_SAMPLES_CONNECTION_STRING')
phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER") # e.g. "+18001234567"
phone_number = os.getenv("AZURE_PHONE_NUMBER") # e.g. "+18001234567"
phone_numbers_client = PhoneNumbersClient.from_connection_string(connection_str)

def get_purchased_phone_number_information():
Expand Down
4 changes: 2 additions & 2 deletions ...ation/azure-communication-phonenumbers/samples/get_purchased_phone_number_sample_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
Set the environment variables with your own values before running the sample:
1) COMMUNICATION_SAMPLES_CONNECTION_STRING - The connection string including your endpoint and
access key of your Azure Communication Service
2) AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER - The phone number you want to get its information
2) AZURE_PHONE_NUMBER - The phone number you want to get its information
"""

import asyncio
Expand All @@ -25,7 +25,7 @@
)

connection_str = os.getenv('COMMUNICATION_SAMPLES_CONNECTION_STRING')
phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER") # e.g. "+18001234567"
phone_number = os.getenv("AZURE_PHONE_NUMBER") # e.g. "+18001234567"
phone_numbers_client = PhoneNumbersClient.from_connection_string(connection_str)

async def get_purchased_phone_number_information():
Expand Down
4 changes: 2 additions & 2 deletions sdk/communication/azure-communication-phonenumbers/samples/release_phone_number_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
Set the environment variables with your own values before running the sample:
1) COMMUNICATION_SAMPLES_CONNECTION_STRING - The connection string including your endpoint and
access key of your Azure Communication Service
2) AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER_TO_RELEASE - The phone number you want to release
2) AZURE_PHONE_NUMBER_TO_RELEASE - The phone number you want to release
"""

import os
Expand All @@ -25,7 +25,7 @@

connection_str = os.getenv('COMMUNICATION_SAMPLES_CONNECTION_STRING')
phone_number_to_release = os.getenv(
"AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER_TO_RELEASE" # e.g. "+18001234567"
"AZURE_PHONE_NUMBER_TO_RELEASE" # e.g. "+18001234567"
)
phone_numbers_client = PhoneNumbersClient.from_connection_string(connection_str)

Expand Down
4 changes: 2 additions & 2 deletions ...mmunication/azure-communication-phonenumbers/samples/release_phone_number_sample_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
Set the environment variables with your own values before running the sample:
1) COMMUNICATION_SAMPLES_CONNECTION_STRING - The connection string including your endpoint and
access key of your Azure Communication Service
2) AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER_TO_RELEASE - The phone number you want to release
2) AZURE_PHONE_NUMBER_TO_RELEASE - The phone number you want to release
"""

import asyncio
Expand All @@ -26,7 +26,7 @@

connection_str = os.getenv('COMMUNICATION_SAMPLES_CONNECTION_STRING')
phone_number_to_release = os.getenv(
"AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER_TO_RELEASE" # e.g. "+18001234567"
"AZURE_PHONE_NUMBER_TO_RELEASE" # e.g. "+18001234567"
)
phone_numbers_client = PhoneNumbersClient.from_connection_string(connection_str)

Expand Down
4 changes: 2 additions & 2 deletions ...ation/azure-communication-phonenumbers/samples/update_phone_number_capabilities_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
Set the environment variables with your own values before running the sample:
1) COMMUNICATION_SAMPLES_CONNECTION_STRING - The connection string including your endpoint and
access key of your Azure Communication Service
2) AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER - The phone number you want to update
2) AZURE_PHONE_NUMBER - The phone number you want to update
"""

import os
Expand All @@ -26,7 +26,7 @@

connection_str = os.getenv('COMMUNICATION_SAMPLES_CONNECTION_STRING')
phone_number_to_update = os.getenv(
"AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER" # e.g. "+15551234567"
"AZURE_PHONE_NUMBER" # e.g. "+15551234567"
)
phone_numbers_client = PhoneNumbersClient.from_connection_string(connection_str)

Expand Down
4 changes: 2 additions & 2 deletions ...azure-communication-phonenumbers/samples/update_phone_number_capabilities_sample_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
Set the environment variables with your own values before running the sample:
1) COMMUNICATION_SAMPLES_CONNECTION_STRING - The connection string including your endpoint and
access key of your Azure Communication Service
2) AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER - The phone number you want to update
2) AZURE_PHONE_NUMBER - The phone number you want to update
"""

import asyncio
Expand All @@ -25,7 +25,7 @@

connection_str = os.getenv('COMMUNICATION_SAMPLES_CONNECTION_STRING')
phone_number_to_update = os.getenv(
"AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER" # e.g. "+15551234567"
"AZURE_PHONE_NUMBER" # e.g. "+15551234567"
)
phone_numbers_client = PhoneNumbersClient.from_connection_string(connection_str)

Expand Down
2 changes: 1 addition & 1 deletion ...nication/azure-communication-phonenumbers/test/test_phone_number_administration_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def setUp(self):
self.phone_number = "sanitized"
self.country_code = "US"
else:
self.phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER")
self.phone_number = os.getenv("AZURE_PHONE_NUMBER")
self.country_code = os.getenv("AZURE_COMMUNICATION_SERVICE_COUNTRY_CODE", "US")
self.phone_number_client = PhoneNumbersClient.from_connection_string(
self.connection_str,
Expand Down
2 changes: 1 addition & 1 deletion ...on/azure-communication-phonenumbers/test/test_phone_number_administration_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def setUp(self):
self.phone_number = "sanitized"
self.country_code = "US"
else:
self.phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER")
self.phone_number = os.getenv("AZURE_PHONE_NUMBER")
self.country_code = os.getenv("AZURE_COMMUNICATION_SERVICE_COUNTRY_CODE", "US")
self.phone_number_client = PhoneNumbersClient.from_connection_string(
self.connection_str,
Expand Down
4 changes: 2 additions & 2 deletions sdk/communication/azure-communication-sms/samples/send_sms_to_multiple_recipients_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
python send_sms_to_multiple_recipients_sample.py
Set the environment variable with your own value before running the sample:
1) COMMUNICATION_SAMPLES_CONNECTION_STRING - the connection string in your ACS resource
2) AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER - a phone number with SMS capabilities in your ACS resource
2) AZURE_PHONE_NUMBER - a phone number with SMS capabilities in your ACS resource
"""

import os
Expand All @@ -27,7 +27,7 @@
class SmsMultipleRecipientsSample(object):

connection_string = os.getenv("COMMUNICATION_SAMPLES_CONNECTION_STRING")
phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER")
phone_number = os.getenv("AZURE_PHONE_NUMBER")

def send_sms_to_multiple_recipients(self):
sms_client = SmsClient.from_connection_string(self.connection_string)
Expand Down
4 changes: 2 additions & 2 deletions ...unication/azure-communication-sms/samples/send_sms_to_multiple_recipients_sample_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
python send_sms_to_multiple_recipients_sample_async.py
Set the environment variable with your own value before running the sample:
1) COMMUNICATION_SAMPLES_CONNECTION_STRING - the connection string in your ACS resource
2) AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER - a phone number with SMS capabilities in your ACS resource
2) AZURE_PHONE_NUMBER - a phone number with SMS capabilities in your ACS resource
"""

import os
Expand All @@ -28,7 +28,7 @@
class SmsMultipleRecipientsSampleAsync(object):

connection_string = os.getenv("COMMUNICATION_SAMPLES_CONNECTION_STRING")
phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER")
phone_number = os.getenv("AZURE_PHONE_NUMBER")

async def send_sms_to_multiple_recipients_async(self):
sms_client = SmsClient.from_connection_string(self.connection_string)
Expand Down
4 changes: 2 additions & 2 deletions sdk/communication/azure-communication-sms/samples/send_sms_to_single_recipient_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
python send_sms_to_single_recipient_sample.py
Set the environment variable with your own value before running the sample:
1) COMMUNICATION_SAMPLES_CONNECTION_STRING - the connection string in your ACS resource
2) AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER - a phone number with SMS capabilities in your ACS resource
2) AZURE_PHONE_NUMBER - a phone number with SMS capabilities in your ACS resource
"""

import os
Expand All @@ -27,7 +27,7 @@
class SmsSingleRecipientSample(object):

connection_string = os.getenv("COMMUNICATION_SAMPLES_CONNECTION_STRING")
phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER")
phone_number = os.getenv("AZURE_PHONE_NUMBER")

def send_sms_to_single_recipient(self):
sms_client = SmsClient.from_connection_string(self.connection_string)
Expand Down
4 changes: 2 additions & 2 deletions ...ommunication/azure-communication-sms/samples/send_sms_to_single_recipient_sample_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
python send_sms_to_single_recipient_sample_async.py
Set the environment variable with your own value before running the sample:
1) COMMUNICATION_SAMPLES_CONNECTION_STRING - the connection string in your ACS resource
2) AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER - a phone number with SMS capabilities in your ACS resource
2) AZURE_PHONE_NUMBER - a phone number with SMS capabilities in your ACS resource
"""

import os
Expand All @@ -28,7 +28,7 @@
class SmsSingleRecipientSampleAsync(object):

connection_string = os.getenv("COMMUNICATION_SAMPLES_CONNECTION_STRING")
phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER")
phone_number = os.getenv("AZURE_PHONE_NUMBER")

async def send_sms_to_single_recipient_async(self):
sms_client = SmsClient.from_connection_string(self.connection_string)
Expand Down
4 changes: 2 additions & 2 deletions sdk/communication/azure-communication-sms/samples/sms_token_credential_auth_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
python sms_token_credential_auth_sample.py
Set the environment variable with your own value before running the sample:
1) COMMUNICATION_SAMPLES_CONNECTION_STRING - the connection string in your ACS resource
2) AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER - a phone number with SMS capabilities in your ACS resource
2) AZURE_PHONE_NUMBER - a phone number with SMS capabilities in your ACS resource
"""

import os
Expand All @@ -29,7 +29,7 @@
class SmsTokenCredentialAuthSample(object):

connection_str = os.getenv('COMMUNICATION_SAMPLES_CONNECTION_STRING')
phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER")
phone_number = os.getenv("AZURE_PHONE_NUMBER")

def sms_token_credential_auth(self):
# To use Azure Active Directory Authentication (DefaultAzureCredential) make sure to have
Expand Down
4 changes: 2 additions & 2 deletions sdk/communication/azure-communication-sms/samples/sms_token_credential_auth_sample_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
python sms_token_credential_auth_sample_async.py
Set the environment variable with your own value before running the sample:
1) COMMUNICATION_SAMPLES_CONNECTION_STRING - the connection string in your ACS resource
2) AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER - a phone number with SMS capabilities in your ACS resource
2) AZURE_PHONE_NUMBER - a phone number with SMS capabilities in your ACS resource
"""

import os
Expand All @@ -30,7 +30,7 @@
class SmsTokenCredentialAuthSampleAsync(object):

connection_string = os.getenv('COMMUNICATION_SAMPLES_CONNECTION_STRING')
phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER")
phone_number = os.getenv("AZURE_PHONE_NUMBER")

async def sms_token_credential_auth_async(self):
# To use Azure Active Directory Authentication (DefaultAzureCredential) make sure to have
Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/azure-communication-sms/tests/test_sms_client_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def setUp(self):
self.recording_processors.extend([
BodyReplacerProcessor(keys=["to", "from", "messageId", "repeatabilityRequestId", "repeatabilityFirstSent"])])
else:
self.phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER")
self.phone_number = os.getenv("AZURE_PHONE_NUMBER")
self.recording_processors.extend([
BodyReplacerProcessor(keys=["to", "from", "messageId", "repeatabilityRequestId", "repeatabilityFirstSent"]),
ResponseReplacerProcessor(keys=[self._resource_name])])
Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/azure-communication-sms/tests/test_sms_client_e2e_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def setUp(self):
self.recording_processors.extend([
BodyReplacerProcessor(keys=["to", "from", "messageId", "repeatabilityRequestId", "repeatabilityFirstSent"])])
else:
self.phone_number = os.getenv("AZURE_COMMUNICATION_SERVICE_PHONE_NUMBER")
self.phone_number = os.getenv("AZURE_PHONE_NUMBER")
self.recording_processors.extend([
BodyReplacerProcessor(keys=["to", "from", "messageId", "repeatabilityRequestId", "repeatabilityFirstSent"]),
ResponseReplacerProcessor(keys=[self._resource_name])])
Expand Down