[Storage][Test] Test multiple service versions #19039
Conversation
seankane-msft
added
Storage
seankane-msft
requested review from
amishra-dev,
annatisch,
tasherif-msft,
xiafu-msft and
zezha-msft
as code owners
| return kwargs.pop("service_version", env_version) | ||
|
|
||
| def create_storage_client(self, client, *args, **kwargs): | ||
| kwargs["api_version"] = self._get_service_version(**kwargs) |
There was a problem hiding this comment.
in nightly pipeline we'd like clients to pick the default, i.e. env variable is empty.
does this code achieve this by leaving "api_version" kwarg empty or we need some "if" here?
There was a problem hiding this comment.
If the environment variable is empty, it will default to LATEST_SERVICE_VERSION
|
A working example would def be great here |
| self.api_version = api_version | ||
|
|
||
| def on_request(self, request): | ||
| assert request.http_request.headers['x-ms-version'] == self.api_version |
There was a problem hiding this comment.
will this throw if env variable is empty? , we should either handle it here or not inject policy if there's no service version provided extrenally.
There was a problem hiding this comment.
No, if the env variable is empty it will default to LATEST_SERVICE_VERSION
| def _get_service_version(self, **kwargs): | ||
| env_version = os.environ.get("AZURE_LIVE_TEST_SERVICE_VERSION", LATEST_SERVICE_VERSION) | ||
| return kwargs.pop("service_version", env_version) |
There was a problem hiding this comment.
Is there a way to not copy code between storage modules? "storage test shared" module would be great.
We have one in .NET, we started one in Java while doing similar changes. Maybe we could use this opportunity to start one in python?
There was a problem hiding this comment.
We can probably put this in devtools_testutils, I'm working on an improvement PR for this that includes code we have shared in tables and storage here
There was a problem hiding this comment.
That'd be great. not a blocker here, but we should do something about all these clones in long term.
There was a problem hiding this comment.
After merging this, I can make changes for that
|
Need to add a decorator to wrap tests for specific service versions |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
[Go]Keyvault add batch tag: package-2021-10 (Azure#19039)
No description provided.