Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[textanalytics] only allow one action per type #19550

Merged
merged 2 commits into from
Jun 29, 2021
Merged

[textanalytics] only allow one action per type #19550

merged 2 commits into from
Jun 29, 2021

Conversation

kristapratico
Copy link
Member

Also adds a test for handling partial action results.

@kristapratico kristapratico self-assigned this Jun 28, 2021
maririos
maririos approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should consider adding this change to the changelog, and some info in the docstrigns too

@kristapratico
Copy link
Member Author

we should consider adding this change to the changelog, and some info in the docstrigns too

Interestingly enough, we already had this limitation written in our docstrings:

https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_text_analytics_client.py#L841`

@kristapratico kristapratico merged commit 9b90f6e into Azure:main Jun 29, 2021
@kristapratico kristapratico deleted the onetask branch June 29, 2021 22:03
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Jul 16, 2021
@kristapratico @rakshith91
[textanalytics] only allow one action per type (Azure#19550)
bc753f3 
* add validation to allow for only one action per type

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maririos maririos maririos approved these changes

@iscai-msft iscai-msft iscai-msft approved these changes

@mssfang mssfang mssfang approved these changes

@abhahn abhahn Awaiting requested review from abhahn

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen

Assignees

@kristapratico kristapratico

Labels
Cognitive - Text Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristapratico @maririos @iscai-msft @mssfang