Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin Crypto Temporarily #21950

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Pin Crypto Temporarily #21950

merged 5 commits into from
Dec 1, 2021

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Dec 1, 2021 •
edited
Loading

The true path forward will be one of two options.

  1. Stop using UsePythonVersion in favor of our own hand-rolled version. It's not too bad, couple hours.
  2. Finish the PR to the task itself. I'm not optimistic about engagement there.

For those of you that are lost. The timeline of events:

  1. crypto 36 released
  2. it started crashing on pypy (even though they ship pypy wheels)

The reason behind this is that the UsePythonVersion task is hardcoded to go after pypy w/2.7 or pypy w/3.6 ONLY. It legit doesn't even parse the versionspec.

@check-enforcer
Copy link

check-enforcer bot commented Dec 1, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@scbedd
Copy link
Member Author

scbedd commented Dec 1, 2021

It's a transient failure, overriding and merging.

@scbedd
Copy link
Member Author

scbedd commented Dec 1, 2021

/check-enforcer override

@scbedd scbedd merged commit 95517c8 into main Dec 1, 2021
@scbedd scbedd deleted the hotfix/address-crypto-failures branch December 1, 2021 06:15
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Dec 1, 2021
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
c77806a 
…into add_body_error

* 'main' of https://github.com/Azure/azure-sdk-for-python: (74 commits)
  Pin Crypto Temporarily (Azure#21950)
  [release-helper] check `default tag` and `target tag` consistency (Azure#21952)
  [EventHubs] remove unused import (Azure#21949)
  [KV] Use shared test-resources.json (Azure#21940)
  [EventHubs] Fix pylint and mypy (Azure#21939)
  fix line in general document sample code (Azure#21936)
  Pipeline auto-discover stress test (Azure#21917)
  resolve the issue the bad condition in dump proxy logs (Azure#21947)
  [KV] Correctly fetch private RSA key material (Azure#21938)
  doc (Azure#21830)
  Sync eng/common directory with azure-sdk-tools for PR 2348 (Azure#21919)
  [EventHubs] ensure ownership arg does not mutate (Azure#20008)
  Fix the type for LROPoller wait timeout (Azure#21913)
  [EventHubs]Update async samples (Azure#21857)
  [AutoRelease] t2-containerservice-2021-11-25-33508 (Azure#21891)
  update for Go (Azure#21898)
  [pipeline] SDK Release helper : 0.0.1 (Azure#21888)
  [AutoRelease] t2-subscription-2021-11-25-24271 (Azure#21892)
  Release issue status (Azure#21887)
  [AutoRelease] t2-datafactory-2021-11-20-87712 (Azure#21840)
  ...
hildurhodd pushed a commit to hildurhodd/azure-sdk-for-python that referenced this pull request Jan 4, 2022
@scbedd @hildurhodd
Pin Crypto Temporarily (Azure#21950)
6f8a44a 
* resolve for 90+% of the packages. the true solution is to stop using UsePythonVersion task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanZzzz RyanZzzz RyanZzzz approved these changes

@zihzhan-msft zihzhan-msft zihzhan-msft approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scbedd @RyanZzzz @zihzhan-msft