migrate identity tests to test proxy #22537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
xiangyan99
requested review from
benbp,
mccoyp,
scbedd and
schaabs
as code owners
mccoyp
reviewed
Apr 11, 2022
|
API change check for API changes are not detected in this pull request for |
mccoyp
reviewed
Apr 12, 2022
...ity/azure-identity/tests/recordings/test_imds_credential.pyTestImdstest_system_assigned.json
Outdated
Show resolved
Hide resolved
Co-authored-by: McCoy Patiño <[email protected]>
xiangyan99
removed request for
lmazuel,
gkostal,
weshaggard,
catalinaperalta,
schaabs,
zfengms,
cRui861,
YalinLi0312,
kristapratico,
paterasMSFT,
iscai-msft,
anilba06,
scbedd,
BigCat20196,
abhahn and
msyyc
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
mccoyp
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
LGTM! You should now be able to use the new recording fixture if you want, which would only involve replacing the @recorded_by_proxy decorators with a recorded_test fixture request (the rest of the test proxy tooling works the same).
I would recommend doing so now so you don't have to later, but this PR has also been up for a while so I won't block you on this 🙂
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Feb 14, 2023
Release apimangement 2022-08 01 (Azure#22313) * Release api management 2022 08 01 (Azure#21169) * add base for 2022-08-01 * updates readme.md * update api-version and examples * resolve Go SDK breaking change * update examples to fix model definition Co-authored-by: Chenjie Shi <[email protected]> * Adding Resolver Entities to documentation (Azure#21352) * merging in resolver entities * adding resolver updates * fixed policy examples that were missing a policyId param * fixed typo that added a nested properties prop * fixed description for API Resolvers List, filter query * fixed error in definitions for resolvers * fixed example that had an incorrect response definition * added missing json file references * fix for linting errors * ref fixes and undoing bad merge overwrites * fix typo * wiki for apis and products (Azure#21595) * wiki for apis and products * prettier; fixed spellchecks * Fixed spelling * Updated path Co-authored-by: changlong-liu <[email protected]> * code review changes; gihub checks fixes * fixed conact name and paths * added properties back * added contract properties objects * fixed lint * changed example to match the definition * prettier * code review changes * added paths and examples for wiki collections * Added x-ms-pageable * removed count Co-authored-by: changlong-liu <[email protected]> * Add ConfirmConsentCode to APIM RP (Azure#22418) * Update apimauthorizationproviders.json Add ConfirmConsentCode endpoint * Update definitions.json * Create ApiManagementPostAuthorizationConfirmConsentCodeRequest.json * Update definitions.json Remove count property * Update apimauthorizationproviders.json * [2022-08-01] Fix Linter Errors (Azure#22537) * linter errors * prettier * v2 * fix error response duplicate schema * type object * prettier * sync data from current ga version * remove duplicate parameter * type object --------- Co-authored-by: Chenjie Shi <[email protected]> Co-authored-by: hoonality <[email protected]> Co-authored-by: malincrist <[email protected]> Co-authored-by: changlong-liu <[email protected]> Co-authored-by: Logan Zipkes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines