Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Batch] Data plane SDK v12.0.0 #22730

Merged
merged 8 commits into from
Feb 1, 2022
Merged

[Batch] Data plane SDK v12.0.0 #22730

merged 8 commits into from
Feb 1, 2022

Conversation

wiboris
Copy link
Member

@wiboris wiboris commented Jan 22, 2022

Description

Updates the SDK to use the 2022-01-01.15.0 API version.

Azure/azure-rest-api-specs#16960

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Batch label Jan 22, 2022
@wiboris wiboris marked this pull request as ready for review January 26, 2022 00:49
tjprescott
tjprescott requested changes Feb 1, 2022
View reviewed changes
Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please remove code-model-v1 from the PR.

sdk/batch/azure-batch/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/batch/azure-batch/CHANGELOG.md Outdated Show resolved Hide resolved
@wiboris wiboris merged commit c506edc into main Feb 1, 2022
@wiboris wiboris deleted the wiboris-batch-data-2022-01-15 branch February 1, 2022 22:05
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@wiboris @rakshith91
[Batch] Data plane SDK v12.0.0 (Azure#22730)
816cd1c 
* updating library for 2022-01-015 changes

* update to tests

* new test recordings

* fixing tests

* updating vm

* updating changelong

* updating doc links

* updates based on feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel left review comments

@tjprescott tjprescott tjprescott approved these changes

@paterasMSFT paterasMSFT paterasMSFT approved these changes

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@dpwatrous dpwatrous Awaiting requested review from dpwatrous dpwatrous is a code owner

@gingi gingi Awaiting requested review from gingi

@zfengms zfengms Awaiting requested review from zfengms

Assignees
No one assigned
Labels
Batch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wiboris @lmazuel @tjprescott @paterasMSFT