[ServiceBus] update auto lock renew strategy with other languages #23557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhaoling
requested review from
annatisch,
swathipil and
rakshith91
as code owners
ghost
added
the
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API changes have been detected in API changes - filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000015A53883070>,
+ filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000014A14BB7070>,
- filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000015A53361DB0>,
+ filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000014A14691DB0>, |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API changes have been detected in API changes - filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000015A53883070>,
+ filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000024C66887070>,
- filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000015A53361DB0>,
+ filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000024C66361D80>, |
|
API changes have been detected in API changes - filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000002656FAC3070>,
+ filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001C0A6807070>,
- filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000002656F5A1D80>,
+ filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001C0A62E1D80>, |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Apr 18, 2023
Feature/cplat 2023 03 01 (Azure#22885) * copy last version to 2023-03-01 folder * update version reference in the new folder * update versions reference in the new folder * add new readme tag with new version * sync with updates made to 2022-11-01 version * fix generation error * fix duplicate enum name thru c# directive instead. * make all the changes to this version that was made to the last version (2022-11-01) to address modelvalidation errors * update * Revert "update" This reverts commit 08417d3ed412ab63c7ee7bdb712ad756ded03c97. * Added $expand option in ListAllVMs and ListAllVMs in RG (Azure#22800) * Added $expand option in ListAllVMs and ListAllVMs in RG * Update virtualMachine.json * dedicatedHost Resize feature (Azure#23268) * dedicatedHost Resize feature * DedicatedHost Sku renamed to size and resolved lint errors. * reviewer comments * httpMethod fix * Add property for VM (Azure#22882) (Azure#23329) Co-authored-by: payalguptapg <[email protected]> * Add Reapply for VMSS (Azure#22344) * Add Reapply for VMSS * Prettier fix * Update examples * Address review comments 01 * Use typical resourceGroupName parameter. * Address review comments - Rename examples * Remove <br> syntax from many descriptions in CRP swagger files (Azure#23019) * up to computeRPCommon * all but computeRPCommons * computerpcommon * vmss clean * common clean * vmss try n * trying only \n * remove \n as it messes with rest docs * cleanup 2022-11-01 accidents * cleanups 2023 * remove ID from Update objects that do not have ID (Azure#23078) * update * add identifiers --------- Co-authored-by: Theodore Chang <[email protected]> * Origin/feature/cplat 2023 03 01 (Azure#23203) * Update virtualMachine.json Added missing property for Additional properties not allowed: provisionAfterExtensions Json path: $.value[*].properties.provisionAfterExtensions * added missing property for provisionAfterExtensions * add locatoin in VirtualMachineScaleSetVMExtension * fixed issue of x-ms-mutability --------- Co-authored-by: Younghyun Kim <[email protected]> * Add securityPostureReference (Azure#23106) * [RestorePoints] Adding Encryption, Source Details, HyperVGeneration and WriteAccelerated for Restore Point (Azure#23303) * Restore Point Encryption Details * Modified descriptions and made DiskRestorePointProperties as input property * Renaming object and adding type * Renaming DiskRestorePointProperties * making DiskRestorePoint.id readOnly * Modifying reference * Running Prettier * Renaming EncryptionType * Adding HyperVGeneration and WriteAcceleratorEnabled (prchin) * Add optional parameter hibernate to vmss deallocate api (Azure#23409) * Add optional parameter hibernate to vmss deallocate api * Fix with prettier * update example for vmss deallocate * Add Spot Related Properties to VMSS PATCH * prettier and lintDiff suppressions * retry lintDiff suppression * lint diff suppression retry * Add managed identities parameters for blobs, add treatFailureAsDeploymentFailure flag for Run Command (Azure#23557) * Add managed identities inputs for script, errorBlob, outputBlob * Add treatFailureAsDeploymentFailure flag * Update proximityPlacementGroup.json (Azure#23556) * Update proximityPlacementGroup.json * Update proximityPlacementGroup.json * Update proximityPlacementGroup.json --------- Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Kartik Gupta <[email protected]> Co-authored-by: cakarata <[email protected]> Co-authored-by: payalguptapg <[email protected]> Co-authored-by: Anshul Verma <[email protected]> Co-authored-by: Adam Sandor <[email protected]> Co-authored-by: younghyun5756 <[email protected]> Co-authored-by: Younghyun Kim <[email protected]> Co-authored-by: krishnak-msft <[email protected]> Co-authored-by: Linu George <[email protected]> Co-authored-by: vatsan28 <[email protected]> Co-authored-by: Viv Lingaiah <[email protected]> Co-authored-by: Micah McKittrick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing issue: #18513
auto lock renewer alignment increases the chance of auto lock renew failure due to the python single thread model and the way auto lock renewer is implemented:
macos and windows tests keep failing in the PR due to the auto lock renewer change.
I think for Python it's better to keep the current strategy and deviate from other languages on this issue.