[pylint] Updating PylintCheckers testing

scripts/pylint_custom_plugin/tests/test_files/__init__.py

@@ -1,3 +1,5 @@
+# Test for CheckNamingMismatchGeneratedCode
+
 from something import Something
 from something2 import something2 as somethingTwo
 

scripts/pylint_custom_plugin/tests/test_files/copyright_header_acceptable.py

@@ -0,0 +1,9 @@
+# ------------------------------------
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+# ------------------------------------
+
+
+class Something():
+    def __init__(self):
+        pass

scripts/pylint_custom_plugin/tests/test_files/copyright_header_violation.py

@@ -0,0 +1,3 @@
+class Something():
+    def __init__(self):
+        pass

scripts/pylint_custom_plugin/tests/test_pylint_custom_plugins.py

@@ -1732,7 +1732,25 @@ def test_guidelines_link_active(self):
 class TestFileHasCopyrightHeader(pylint.testutils.CheckerTestCase):
     CHECKER_CLASS = checker.FileHasCopyrightHeader
 
-    # Unable to use the astroid for this testcase.
+    def test_copyright_header_acceptable(self):
+        file = open("./test_files/copyright_header_acceptable.py")
+        node = astroid.parse(file.read())
+        file.close()
+
+        with self.assertNoMessages():
+            self.checker.visit_module(node)
+
+    def test_copyright_header_violation(self):
+        file = open("./test_files/copyright_header_violation.py")
+        node = astroid.parse(file.read())
+        file.close()
+
+        with self.assertAddsMessages(
+                pylint.testutils.Message(
+                    msg_id="file-needs-copyright-header", node=node
+                )
+        ):
+            self.checker.visit_module(node)
 
     def test_guidelines_link_active(self):
         url = "https://azure.github.io/azure-sdk/policies_opensource.html"
@@ -2157,6 +2175,89 @@ def test_guidelines_link_active(self):
         response = client._pipeline.run(request)
         assert response.http_response.status_code == 200
 
+class TestPackageNameDoesNotUseUnderscoreOrPeriod(pylint.testutils.CheckerTestCase):
+    CHECKER_CLASS = checker.PackageNameDoesNotUseUnderscoreOrPeriod
+
+    def test_package_name_acceptable(self):
+
+        package_name =  astroid.extract_node(
+        """
+        PACKAGE_NAME = "correct-package-name"        
+        """ 
+        )
+        module_node = astroid.Module(name = "node", file="setup.py", doc = """ """)
+        module_node.body = [package_name]
+
+        with self.assertNoMessages():
+            self.checker.visit_module(module_node)
+
+    def test_package_name_violation(self):
+
+        package_name =  astroid.extract_node(
+        """
+        PACKAGE_NAME = "incorrect.package-name"        
+        """ 
+        )
+        module_node = astroid.Module(name = "node", file="setup.py", doc = """ """)
+        module_node.body = [package_name]
+
+        with self.assertAddsMessages(
+                pylint.testutils.Message(
+                    msg_id="package-name-incorrect", node=module_node
+                )
+        ):
+            self.checker.visit_module(module_node)
+
+    def test_guidelines_link_active(self):
+        url = "https://azure.github.io/azure-sdk/python_design.html#packaging"
+        config = Configuration()
+        client = PipelineClient(url, config=config)
+        request = client.get(url)
+        response = client._pipeline.run(request)
+        assert response.http_response.status_code == 200
+
+class TestServiceClientUsesNameWithClientSuffix(pylint.testutils.CheckerTestCase):
+    CHECKER_CLASS = checker.ServiceClientUsesNameWithClientSuffix
+
+    def test_client_suffix_acceptable(self):
+        client_node =  astroid.extract_node(
+        """
+        class MyClient():
+            def __init__(self):
+                pass       
+        """ 
+        )
+        module_node = astroid.Module(name = "node", file="_my_client.py", doc = """ """)
+        module_node.body = [client_node]
+
+        with self.assertNoMessages():
+            self.checker.visit_module(module_node)
+
+    def test_client_suffix_violation(self):
+        client_node =  astroid.extract_node(
+        """
+        class Violation():
+            def __init__(self):
+                pass       
+        """ 
+        )
+        module_node = astroid.Module(name = "node", file="_my_client.py", doc = """ """)
+        module_node.body = [client_node]
+        with self.assertAddsMessages(
+                pylint.testutils.Message(
+                    msg_id="client-suffix-needed", node=module_node
+                )
+        ):
+            self.checker.visit_module(module_node)
+
+    def test_guidelines_link_active(self):
+        url = "https://azure.github.io/azure-sdk/python_design.html#service-client"
+        config = Configuration()
+        client = PipelineClient(url, config=config)
+        request = client.get(url)
+        response = client._pipeline.run(request)
+        assert response.http_response.status_code == 200
+
 
 class TestClientMethodNamesDoNotUseDoubleUnderscorePrefix(pylint.testutils.CheckerTestCase):
     CHECKER_CLASS = checker.ClientMethodNamesDoNotUseDoubleUnderscorePrefix
@@ -2341,7 +2442,6 @@ def test_guidelines_link_active(self):
         response = client._pipeline.run(request)
         assert response.http_response.status_code == 200
 
-
 class TestCheckDocstringAdmonitionNewline(pylint.testutils.CheckerTestCase):
     CHECKER_CLASS = checker.CheckDocstringAdmonitionNewline
 
@@ -2573,17 +2673,7 @@ def __init__(self):
 class TestCheckNamingMismatchGeneratedCode(pylint.testutils.CheckerTestCase):
     CHECKER_CLASS = checker.CheckNamingMismatchGeneratedCode
 
-    def test_ignores_correct_alias_code(self):
-        module_node = astroid.extract_node(
-            """
-            import something as somethingElse
-            """
-        )
-
-        with self.assertNoMessages():
-            self.checker.visit_module(module_node)
-
-    def test_catches_incorrect_import_alias_code(self):
+    def test_import_naming_mismatch_violation(self):
         import_one = astroid.extract_node(
             'import Something'
 
@@ -2614,7 +2704,7 @@ def test_catches_incorrect_import_alias_code(self):
         ):
             self.checker.visit_module(module_node)
 
-    def test_catches_incorrect_from_import_alias_code(self):
+    def test_import_from_naming_mismatch_violation(self):
         import_one = astroid.extract_node(
             'import Something'
 
@@ -2645,7 +2735,7 @@ def test_catches_incorrect_from_import_alias_code(self):
         ):
             self.checker.visit_module(module_node)
 
-    def test_ignores_unaliased_import_init(self):
+    def test_naming_mismatch_acceptable(self):
         import_one = astroid.extract_node(
             'import Something'
 
@@ -2669,7 +2759,7 @@ def test_ignores_unaliased_import_init(self):
         with self.assertNoMessages():
             self.checker.visit_module(module_node)
 
-    def test_disable_pylint_alias(self):
+    def test_naming_mismatch_pylint_disable(self):
 
         file = open("./test_files/__init__.py")
         node = astroid.parse(file.read())
@@ -2678,6 +2768,14 @@ def test_disable_pylint_alias(self):
         with self.assertNoMessages():
             self.checker.visit_module(node)
 
+    def test_guidelines_link_active(self):
+        url = "https://github.com/Azure/autorest/blob/main/docs/generate/built-in-directives.md"
+        config = Configuration()
+        client = PipelineClient(url, config=config)
+        request = client.get(url)
+        response = client._pipeline.run(request)
+        assert response.http_response.status_code == 200
+
 class TestCheckEnum(pylint.testutils.CheckerTestCase):
     CHECKER_CLASS = checker.CheckEnum
 
@@ -2784,6 +2882,19 @@ def test_enum_file_both_violation(self):
 
             self.checker.visit_classdef(node.body[1])
 
+    def test_guidelines_link_active(self):
+        response_one = self._create_url_pipeline("https://azure.github.io/azure-sdk/python_design.html#enumerations")
+        assert response_one.http_response.status_code == 200
+        response_two = self._create_url_pipeline("https://azure.github.io/azure-sdk/python_implementation.html#extensible-enumerations")
+        assert response_two.http_response.status_code == 200
+
+    def _create_url_pipeline(self,url):
+        config = Configuration()
+        client = PipelineClient(url, config=config)
+        request = client.get(url)
+        response = client._pipeline.run(request)
+        return response
+
 
 class TestCheckAPIVersion(pylint.testutils.CheckerTestCase):
     CHECKER_CLASS = checker.CheckAPIVersion
@@ -2836,7 +2947,6 @@ def test_api_version_file_init_acceptable(self):
         node = astroid.parse(file.read())
         file.close()
 
-
         with self.assertNoMessages():
             self.checker.visit_classdef(node.body[0])
 
@@ -2852,3 +2962,11 @@ def test_api_version_file_violation(self):
                 )
         ):
             self.checker.visit_classdef(node.body[0])
+
+    def test_guidelines_link_active(self):
+        url = "https://azure.github.io/azure-sdk/python_design.html#specifying-the-service-version"
+        config = Configuration()
+        client = PipelineClient(url, config=config)
+        request = client.get(url)
+        response = client._pipeline.run(request)
+        assert response.http_response.status_code == 200