Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pylint] Remove cosmos from pylintrc #24205

Closed
wants to merge 41 commits into from

Commits on Mar 17, 2022

  1. [pylint] alias checker and tests (Azure#23471)

    * intro patch for aliasing - needs better way to grab __all__ info
    
    * updated alias message
    
    * line number shows up with alias warning
    
    * working on testing this, slight mod to isinstance
    
    * tests for aliasing
    
    * updated docstring
    
    * removing random import
    
    * adding in a newline
    
    * adding in a newline
    
    * changing naming of error message
    
    * changing package to model in except
    
    * checking for only __all__ assign Node (cat)
    
    * added alias checker to README
    
    * added test file to test disable pylint warning
    
    * add from import test
    
    * removed unused imports
    
    * changing test names for clarity
    
    * added newline
    
    * added link from Izzy
    
    * fixed some issues with the links
    
    * fixed some issues with the links2
    
    * fix for running core on pylint pr
    
    * removed cr
    
    * checking ignore files
    
    * seeing if ignore file will fix core breaks
    
    * fix path in ci
    
    * removed ignore
    
    * removed ignore file
    
    * rerun
    
    * removing core
    
    * made 2 for loops to figure out why search is not catching in core run
    
    * core
    
    * remvoing core
    
    * renaming to naming_mismatch
    
    * fix message name
    
    * fixing naming issues
    
    * naming init
    
    * naming register
    
    * changing name to align with checker name change
    
    * fixed messaging
    
    * fixing pylint error
    
    * found a less invasive way to get to the model name in __all__
    
    * reverting back to originally bc init can have more than 1 assign
    l0lawrence authored Mar 17, 2022
    Configuration menu
    Copy the full SHA
    57f5122 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. [pylint] Api checker (Azure#23500)

    * setting remote
    
    * setting up api version checker
    
    * api checker
    
    * running core to see where error pops up
    
    * trying to get tests to run
    
    * python versioning and kwargs will change this
    
    * checking docstring for api version keyword
    
    * added basic test for docstring api_version
    
    * adding in a test file for api version checker
    
    * edit test file
    
    * removing import that got added
    
    * added newline:
    
    * remvoing scripts from pipeline
    
    * added newline:
    
    * added in check for init doc too
    
    * added in a test for init having the doc versus the init
    
    * had to make tests go down to the class level to run test files
    
    * fixing naming schema and docs for api checker - renamed error
    
    * instead of splitting the doc - directly check for the keyword api_version string
    
    * renaming file to match other test files
    
    * switching around the order of keyword and param to see the effect on the checker
    
    * renaming changed file name in test
    
    * added api checker to the readme
    
    * refactoring - if class doc has api_verison, skip looking at the init func
    
    * fixing docstring on bad test
    
    * changing credential type in test docstring
    
    * adding in endpoint as an arg in the init
    
    * addind endpoint as arg in init
    
    * adding endpoint as arg
    
    * updating test file names to follow acceptable and violation format
    
    * updating file names in tests, and updating test function names to follow violation and acceptable trend
    
    * fixing eof newline errors
    
    * trying to get commits into pr
    
    * eof newline
    
    * changing class name to APIVersion instead of api
    
    * init file, also updated APIVersion name
    
    * adding end colon to api_verion str checking
    
    * added in end colon to node.doc check too
    l0lawrence authored Mar 24, 2022
    Configuration menu
    Copy the full SHA
    0db0219 View commit details
    Browse the repository at this point in the history
  2. [pylint] adding in correct links for pylint (Azure#23503)

    * adding in correct links for pylint
    
    * added in better links
    
    * updating links
    
    * updating links
    
    * add in url to tests
    
    * add in url to tests
    
    * fixed disable in README for client-method-should-not-use-static-method
    
    * fixing merge issue in readme with api_checker
    l0lawrence authored Mar 24, 2022
    Configuration menu
    Copy the full SHA
    0f5f9f0 View commit details
    Browse the repository at this point in the history
  3. Enum cases (Azure#23571)

    * setting upstream
    
    * start of enum checker
    
    * wip enum cehcker
    
    * passing basic test, need to only check enum
    
    * adding tests for enum
    
    * removed print statements
    
    * tests
    
    * added in check that class is Enum related
    
    * adding rule for caseInsensitiveMeta
    
    * had to change how to check for Enum b/c Meta makes it a Call Node
    
    * added in a test for CaseInsensitive
    
    * random import
    
    * added to readme
    
    * changed regsistered name
    
    * fixed checker for uppercase so it references correct line
    
    * fixed test to reflect line change in checker
    
    * removing excess ==
    
    * add new line
    
    * seeing where enum checker will fail
    
    * rerun
    
    * remove alias
    
    * removing alias for ci
    
    * added in consideration for python3 meta syntax
    
    * fixed error assuming metaclass exists
    
    * adding enum class check
    
    * missing an init
    
    * removing the alias from readme
    
    * fix docstring for enum class
    
    * removing core
    
    * enum checker update comments
    
    * editing comments on checker
    
    * refactoring for 2 diff syntaxes:
    
    * added test file for enum
    
    * removed _CaseInsensitiveEnumMeta
    
    * some syntax changing
    
    * fixing comments
    
    * list is superfluous:
    
    * removing the import that was default added for Node
    
    * fixing space in comment, and removing if arg.name - pr comments
    
    * edited test files, to test for both errors being thrown in the same enum class - pr comments
    
    * fixing naming of test methods for readability
    
    * split the enum checker into 2 private functions for the 2 different rules
    
    * making if into elif on 1783 and 1800 to prevent breaking when python2 enum format
    
    * renaming test files -pr comments
    
    * python3 enum inherit class checker now uses _metaclass versus declared_metaclass()
    
    * added in test for python 3 metaclass format
    
    * enum_code now uses helper functions to return a boolean for both pylint guidelines
    
    * adding a test to verify metaclass syntax ensures the MetaClass is the 1st argument arg[0]
    
    * removing unused test files
    
    * renaming test names to follow _violation and _acceptable pattern
    
    * fixing inheritance of enummeta class format
    
    * added in docstrings for the helper functions created
    
    * adding newline at eof
    
    * removing spaces from the eof line for github error
    
    * clarifying enum_class helper function docstring
    
    * fixing docstring edits
    
    * returning booleans versus returning the individual variable
    
    * collapsing inherit helper function to call message directly instead
    
    * adding newline to eof
    
    * updating _check_is_enum_class docstring return, rtype
    
    * adding in import statement for metaclass, and enum to tests
    
    * had to import with_metaclass for py2
    
    * had to also import with_metaclass for python2 tests
    
    * using declared_metaclass() instead of metaclass to get the metaclass for both py2 and py3 syntax
    
    * removing uneeded for loop and now we are directly checking enum within the bases (arguments) of the class node
    
    * collapsing a helper method to simplify logic of checker
    
    * fixing indentation of tests
    
    * adding space in api version error
    l0lawrence authored Mar 24, 2022
    Configuration menu
    Copy the full SHA
    75b27d0 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python

    …into feature/pylint-plugins
    l0lawrence committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    bac1410 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Configuration menu
    Copy the full SHA
    70785a9 View commit details
    Browse the repository at this point in the history
  2. [pylint] Updating PylintCheckers testing (Azure#23707)

    * Updating CheckNamingMismatchGeneratedCode testing - naming convention and adding guidelines link test
    
    * Updating CheckEnum test suite - added test for readme guideline links
    
    * CheckAPIVersion added test for guidelines link
    
    * FileHasCopyrightHeader added in test files to test for copyright header checker
    
    * created TestPackageNameDoesNotUseUnderscoreOrPeriod
    
    * TestPackageNameDoesNotUseUnderscoreOrPeriod adding guidelines link test
    
    * added in TestServiceClientUsesNameWithClientSuffix test class
    
    * fixed newline issues at end of file
    
    * added guidelines link into NamingMismatchGeneratedCode warning:
    
    * fixed PR comments with helper function for guidelines - import requests
    l0lawrence authored Mar 30, 2022
    Configuration menu
    Copy the full SHA
    cac39db View commit details
    Browse the repository at this point in the history
  3. using base code from ClientListMethodsUseCorePaging, added on check f…

    …or a custom paging class, and comparison with docstring rtype
    l0lawrence committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    8c92a97 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. Configuration menu
    Copy the full SHA
    3275972 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fcca92e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9d55095 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4710b72 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. removing unused import

    l0lawrence committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    b5bba99 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cdc41b3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2e25822 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5738b05 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9e02b18 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2cdd87e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4ea4ba5 View commit details
    Browse the repository at this point in the history
  8. adding rule to readme

    l0lawrence committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    310ed90 View commit details
    Browse the repository at this point in the history
  9. updating comments

    l0lawrence committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    4eda9bb View commit details
    Browse the repository at this point in the history
  10. removing uneeded test

    l0lawrence committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    282d2a4 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Configuration menu
    Copy the full SHA
    3f4f794 View commit details
    Browse the repository at this point in the history
  2. comparing lowercase versions of both types to deal with 3.8 versus 3.…

    …9 list/set/dict inherit from typing change
    l0lawrence committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    6af0751 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a27ef9c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    96393a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Configuration menu
    Copy the full SHA
    4c21023 View commit details
    Browse the repository at this point in the history
  2. removing import

    l0lawrence committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    efd1a3b View commit details
    Browse the repository at this point in the history
  3. changing the way we infer the return type - iterate into the class to…

    … infer type and check if returning a func i.e ItemPaged()
    l0lawrence committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    b2c6c2e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    02f5255 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    55a2804 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Configuration menu
    Copy the full SHA
    75b5df6 View commit details
    Browse the repository at this point in the history
  2. fixing test naming

    l0lawrence committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    e1d6a68 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2bb0a6a View commit details
    Browse the repository at this point in the history
  4. fixing paged

    l0lawrence committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    5e431a1 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Configuration menu
    Copy the full SHA
    f56c26b View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. kristas comment: can't check if is a function call b/c we will throw …

    …false positives for generated code like new test
    l0lawrence committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    dc039fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4de4f2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    84b2613 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2022

  1. fixing merge conflicts

    l0lawrence committed Apr 25, 2022
    Configuration menu
    Copy the full SHA
    db21453 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Configuration menu
    Copy the full SHA
    28a9b3e View commit details
    Browse the repository at this point in the history