Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML][Pipelines] Validate pipeline node IO name on reserved word #28770

Merged
merged 7 commits into from
Feb 13, 2023
Merged

[ML][Pipelines] Validate pipeline node IO name on reserved word #28770

merged 7 commits into from
Feb 13, 2023

Conversation

zhengfeiwang
Copy link
Member

@zhengfeiwang zhengfeiwang commented Feb 13, 2023

Description

In current IO implementation, IO inherits from Python built-in dictionary, this results in unexpected error when IO name uses same name as built-in attribute/method. This PR targets to add validation on pipeline node IO name, log warning if IO name is these reversed word (built-in attribute/method in dict), suggest access via <node-name>.inputs/outputs["<input/output-name>"].

The warning will look like:

image

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@wangchao1230 wangchao1230 merged commit e94435e into Azure:main Feb 13, 2023
@zhengfeiwang zhengfeiwang deleted the bugfix/keywords-in-io branch February 14, 2023 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants