[Storage] [Hotfix] Fix breaking change in create_configuration and prepare patches
#32071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalauzon-msft
requested review from
annatisch and
vincenttran-msft
as code owners
|
API change check API changes are not detected in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised in #32056, a change in our latest release broke callers of the
create_configurationmethod by requiring thesdk_monikerkeyword be passed rather than the existingstorage-sdkkeyword.While
create_configurationis not an exported method and therefore is not meant to be called by users of the SDK directly, adlfs is calling it and therefore broke with the latest release. The fastest fix foradlfsis likely to patch the SDKs, despite this not technically being a publicly facing breaking change, so this change makes the fix and prepares for a patch release of all the Storage SDKs.