Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracer_provider kwarg to AzureMonitorTraceExporter #36363

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

avramdj
Copy link
Contributor

@avramdj avramdj commented Jul 4, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter labels Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Thank you for your contribution @avramdj! We will review the pull request and get back to you soon.

@avramdj
Copy link
Contributor Author

avramdj commented Jul 4, 2024

#36362

@avramdj avramdj changed the title Add tracer_provider kwarg to AzureMonitorTraceExporter Add tracer_provider kwarg to AzureMonitorTraceExporter Jul 4, 2024
@lzchen
Copy link
Member

lzchen commented Jul 5, 2024

@avramdj

Thanks for the contribution! Please add a CHANGELOG entry and add a test for this to show that a custom TracerProvider can be used.

@annatisch
Copy link
Member

Hi @avramdj - just wanted to check in as to whether you wanted to keep working on this PR?
Otherwise @lzchen do you want to finish up this PR?

@avramdj
Copy link
Contributor Author

avramdj commented Sep 4, 2024

@microsoft-github-policy-service agree

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-monitor-opentelemetry-exporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants