Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning the htmlcov directory #4332

Merged
merged 4 commits into from
Feb 11, 2019
Merged

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Feb 7, 2019

The code coverage tab in DevOps when all azure-* packages are built NEVER displays. It just spins forever.

The reason for this is that coverage html generates an html page for every single test. This means that the the build artifacts for the cobertura report contains about 6k html files that prevent the UI from ever loading (huge download).

@scbedd scbedd requested a review from lmazuel as a code owner February 7, 2019 23:10
@adxsdk6
Copy link

adxsdk6 commented Feb 7, 2019

Can one of the admins verify this patch?

1 similar comment
@adxsdk6
Copy link

adxsdk6 commented Feb 7, 2019

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented Feb 7, 2019

Codecov Report

Merging #4332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4332   +/-   ##
=======================================
  Coverage   53.53%   53.53%           
=======================================
  Files       10452    10452           
  Lines      218687   218687           
=======================================
  Hits       117066   117066           
  Misses     101621   101621

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3195be7...afe546b. Read the comment docs.

Copy link
Member

@bsiegel bsiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion

scripts/devops_tasks/inline_css_for_cobertura.py Outdated Show resolved Hide resolved
Copy link
Member

@bsiegel bsiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍✨Ship It✨:shipit:

Note: Please pull latest master and rebase this branch onto it before merging this pull request.

$ git checkout master
$ git pull origin master

$ git checkout -
$ git rebase master

$ git push -f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants