Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce PR test matrix to python 2.7, 3.5 and 3.8 #9031

Merged
merged 4 commits into from
Dec 6, 2019

Conversation

praveenkuttappan
Copy link
Member

PR will run test only for 2.7, 3.5 and 3.8
CI and live test will continue to run for all versions as earlier.

scbedd
scbedd previously approved these changes Dec 6, 2019
eng/pipelines/templates/jobs/archetype-sdk-client.yml Outdated Show resolved Hide resolved
@praveenkuttappan
Copy link
Member Author

@weshaggard : I have updated this PR as per your suggestion to create test matrix within one yml itself.

@praveenkuttappan praveenkuttappan merged commit 7df57f3 into Azure:master Dec 6, 2019
@praveenkuttappan praveenkuttappan deleted the reducetestmatrix branch December 6, 2019 22:02
OSVmImage: 'ubuntu-16.04'
PythonVersion: '3.6'
CoverageArg: ''
RunForPR: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that it matters too much but can we get away with out listing the CoverageARg and RunForPr = false entries? It would help cut down on the size of this matrix table.

-e ../../../tools/azure-sdk-tools
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What changed here?

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome this looks a lot better. I added one comment about potential clean-up if possible.

@praveenkuttappan
Copy link
Member Author

praveenkuttappan commented Dec 6, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants