move to using Arc<dyn HttpClient>
in azure_identity
#799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From discussions in a previous PR, the more common method in the SDK is to clone the
Arc<dyn HttpClient>
, rather than pass a reference.#785 (comment)
Note, this uses the crate fix-hidden-lifetime-bug to work around an issue with async fn trait issues (ref: rust-lang/rust#63033).
Without this workaround, we see the error: