Implement tool for retrieving owners of all repository files. #5135
Assignees
Labels
Central-EngSys
This issue is owned by the Engineering System team.
Comments
konrad-jamrozik
added
the
Central-EngSys
ghost
pushed a commit
that referenced
this issue
Jan 14, 2023
…r all paths matching given glob path. (#5134) This PR implements for the `retrieve-codeowners` tool the ability to return not only owners for a single path, but a list of all owners for all paths resolved when matching a glob path given as input. As such, this PR contributes to: - #5135 This work is necessary to be able to compare and diff the owners of all files in repository before and after the regex matcher is turned on, per this comment: - #5088 (review) In other words, this PR contributes to unblocking to the following PR: - #5088 And as such, also contributes to: - #2770 This PR will require some upstream changes, which are captured by: - #5103 ### Additional changes - Removed logger from `CodeOwnersParser`; replaced with `Console.Out` and `Console.Error`. This addresses the following comment: - #5063 (comment) - Prevented the new regex matcher from matching paths that have `*` in them - such paths are malformed anyway (at least on Windows). - A lot of assorted changes to surrounding production & test code - please see the file diff for details. ### Implementation notes This PR leverages [`Microsoft.Extensions.FileSystemGlobbing`](https://www.nuget.org/packages/Microsoft.Extensions.FileSystemGlobbing). Doc: https://learn.microsoft.com/en-us/dotnet/core/extensions/file-globbing
This was referenced Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We need to be able to deduce which files in given repository have which owners, as we are:
CODEOWNERSmatcher that supports wildcards. See:retrieve-codeownerstool support for returning owners for all paths matching given glob path. #5134CODEOWNERSvalidation, which will require file cleanup. See: Implement CODEOWNERS file changes validation (gating), with baselining #4859The idea here is to augment the
retrieve-codeownerstool with the new ability. This will change its input params, and hence will require upstream dependees changes.The text was updated successfully, but these errors were encountered: