Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor eng/common/README.md #1178

Merged
2 commits merged into from
Nov 10, 2020
Merged

Refactor eng/common/README.md #1178

2 commits merged into from
Nov 10, 2020

Conversation

chidozieononiwu
Copy link
Member

Move Common Engineering System Doc to main README.md Doc.
Add information for how to structure unique language logic.

@chidozieononiwu chidozieononiwu requested a review from a team as a code owner November 7, 2020 00:21
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Nov 9, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
weshaggard
weshaggard reviewed Nov 9, 2020
View reviewed changes
eng/common/README.md Outdated Show resolved Hide resolved
@chidozieononiwu chidozieononiwu requested review from weshaggard and a team November 9, 2020 18:51
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

This was referenced Nov 10, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
js - template
net - template
python - template
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Nov 10, 2020

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 2c58ce4 into Azure:master Nov 10, 2020
@chidozieononiwu chidozieononiwu mentioned this pull request Nov 11, 2020
Closed
benbp pushed a commit that referenced this pull request Dec 1, 2020
@chidozieononiwu @benbp
Refactor eng/common/README.md (#1178)
3e32c6e 
Move Common Engineering System Doc to main README.md Doc.
Add information for how to structure unique language logic.
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
@ericwolz
IoT SDK review updates (Azure#1178)
a3ad79c 
* az_iot_is_retriable_status

* update

* update

* update

* doc update

* update change log

* fix doxgen build break

* fixed PR issues

* added more context to global_device_hostname

* Update .gitignore

* Update CHANGELOG.md

* pr review

* Update az_iot_provisioning_client.c
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchdenny mitchdenny mitchdenny approved these changes

@weshaggard weshaggard weshaggard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chidozieononiwu @azure-sdk @mitchdenny @weshaggard