Move entire docgeneration into common tools #1219
Conversation
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
Co-authored-by: Wes Haggard <[email protected]>
| console.log("Run PopulateList") | ||
|
|
||
| $('h4').each(function () { | ||
| var pkgName = $(this).text().replace(PACKAGE_REGEX, PACKAGE_REPLACEMENT) |
There was a problem hiding this comment.
Does this work correctly if the REGEX is empty?
Also I assume you added this to handle the JS case correct?
| # Update main.js package regex and replacement | ||
| $mainJsContent = $mainJsContent -replace "var PACKAGE_REGEX = ''", "var PACKAGE_REGEX = '$packageRegex'" | ||
| $mainJsContent = $mainJsContent -replace "var PACKAGE_REPLACEMENT = ''", "var PACKAGE_REPLACEMENT = '$regexReplacement'" | ||
| Set-Content -Path $MainJsPath -Value $mainJsContent |
There was a problem hiding this comment.
Given you used the -Raw option in get-content you should use -NoNewLine in the set-content.
| # Update main.js var index html | ||
| $mainJsContent = $mainJsContent -replace "var INDEX_HTML = ''", "var INDEX_HTML = '$indexhtmlloc'" | ||
| # Update main.js package regex and replacement | ||
| $mainJsContent = $mainJsContent -replace "var PACKAGE_REGEX = ''", "var PACKAGE_REGEX = $packageRegex" |
There was a problem hiding this comment.
Should $packageRegex have quotes around it?
There was a problem hiding this comment.
JS actually read regex as only surrounded /.../ without quotes
There was a problem hiding this comment.
Tested in JS, will test the rest repo as well
| populateOptions($('#navbar'), pkgName) | ||
| } | ||
| }) | ||
|
|
There was a problem hiding this comment.
nit: There are a lot of empty lines at the end of this file that can be removed.
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Several features add-on:
Tested in Java