Remove old Update-Change-Log.ps1

[chidozieononiwu]

• Remove eng\common\Update-Change-Log.ps1

[azure-sdk]

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

[mitchdenny]

Curious about this, why can't you do this?

[chidozieononiwu]

This is because of how the script is called here. PowerShell in converting to Boolean results in true for both "true" and "false"

[mitchdenny]

I'd normally use a [switch] type for this kinds of options in PowerShell, example:

function Do-Stuff
{
  param(
    [switch]$FooSwitch
  )

  Write-Host $FooSwitch
}

When you invoke this function you can do this:

Do-Stuff
Output: False

Do-Stuff -FooSwitch
Output: True

Do-Stuff -FooSwtich:$false
Output: False

Do-Stuff -FooSwitch:$([System.Boolean]::Parse("false"))
Output: False

Do-Stuff -FooSwitch:$([System.Boolean]::Parse("true"))
Output: True

In short PowerShell provides the mechanisms to declare these kinds of switches and pass in true-false values.

[chidozieononiwu]

Oh, I see.
Do you know how the switch will be invoked from JS

[weshaggard]

Yes I expect the switch to work fine from anywhere (Note that -FooSwitch:0/1 also works). The key with using a switch is to use a term that means the variable defaults to false and so folks will only ever pass it if they want to set it to true.

[mitchdenny]

It looks like the array that is passed into the spawn command is just the argument list. But it looks like pwsh.exe has a nice little affordance where you can invoke it like this:

pwsh.exe [script] [args]

For example:

pwsh.exe Do-Stuff.ps1 -FooSwitch:false

(note you don't need to do the [System.Boolean] thing.

[chidozieononiwu]

@weshaggard Unfortunately -FooSwitch:0/1 does not work. This does work though -FooSwitch:$true

[weshaggard]

LGTM - Make sure this goes in after your other updates to the language repos.

[ghost]

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[chidozieononiwu]

/check-enforcer override