Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow propogation of SetDevVersion. #1579

Merged
merged 2 commits into from
May 3, 2021
Merged

Allow propogation of SetDevVersion. #1579

merged 2 commits into from
May 3, 2021

Conversation

mitchdenny
Copy link
Contributor

@mitchdenny mitchdenny commented Apr 28, 2021 •
edited
Loading

This PR adds a task which takes the SetDevVersion property which is local to the job and exports so it can be used across jobs and stages. Example usage:

- stage: Integration
  variables:
    SetDevVersion: $[stageDependencies.Build.Build.outputs['VersioningProperties.SetDevVersion']]

@mitchdenny mitchdenny requested a review from a team as a code owner April 28, 2021 04:53
@mitchdenny mitchdenny self-assigned this Apr 28, 2021
@mitchdenny mitchdenny added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Apr 28, 2021
@mitchdenny mitchdenny mentioned this pull request Apr 28, 2021
Closed
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming my one question is fine the change looks good.

@mitchdenny
Copy link
Contributor Author

Assuming my one question is fine the change looks good.

We are fine. I'll roll this one out.

This was referenced Apr 29, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@mitchdenny
Copy link
Contributor Author

Assuming my one question is fine the change looks good.

We are fine. I'll roll this one out.

Actually I was wrong .... sigh. I did some verification just to make sure and it appears that it scopes the output based on name. So I'm going to need to append a bit of logic to make this work properly.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented May 3, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@mitchdenny
Copy link
Contributor Author

/check-enforcer evaluate

@mitchdenny mitchdenny merged commit a78f573 into Azure:master May 3, 2021
@mitchdenny mitchdenny deleted the enable-variable-propogation-across-stages branch May 3, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

Assignees

@mitchdenny mitchdenny

Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitchdenny @azure-sdk @weshaggard