-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch all Tools to net feed #1853
Switch all Tools to net feed #1853
Conversation
chidozieononiwu
commented
Jul 28, 2021
- Publish all nuget tools to the azure-sdk-for-net DevOps feed using a single pipeline.
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: |
@@ -0,0 +1,27 @@ | |||
# NOTE: Please refer to https://aka.ms/azsdk/engsys/ci-yaml before editing this file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be a follow-up but we should probably move things from src/dotnet to tools directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. Please make sure that all the pipelines run and work as expected.
360c4ef
to
75b9194
Compare
75b9194
to
03c6ed5
Compare
85b27ac
to
ce554ac
Compare
@@ -0,0 +1,27 @@ | |||
# NOTE: Please refer to https://aka.ms/azsdk/engsys/ci-yaml before editing this file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pipeline doesn't seem to be triggering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chidozieononiwu You didn't create a public pipeline for this ci.yml only an internal one. I renamed the old azure-sdk-tools - dotnet pipeline in public to tools - Azure.ClientSdk.Analyzers - ci to fix this. You might also need to setup a public pipeline for the snippet generator.