Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource clean-up script #1902

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Conversation

weshaggard
Copy link
Member

Fixed "rg.Name" to "rg.ResourceGroupName" and added some extra logging.

@weshaggard weshaggard requested a review from a team as a code owner August 13, 2021 17:28
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member Author

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@weshaggard
Copy link
Member Author

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

eng/common/scripts/Helpers/Resource-Helpers.ps1 Outdated Show resolved Hide resolved
eng/common/scripts/Helpers/Resource-Helpers.ps1 Outdated Show resolved Hide resolved
eng/common/scripts/Helpers/Resource-Helpers.ps1 Outdated Show resolved Hide resolved
eng/common/scripts/Helpers/Resource-Helpers.ps1 Outdated Show resolved Hide resolved
eng/scripts/live-test-resource-cleanup.ps1 Outdated Show resolved Hide resolved
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

eng/common/scripts/Helpers/Resource-Helpers.ps1 Outdated Show resolved Hide resolved
eng/common/scripts/Helpers/Resource-Helpers.ps1 Outdated Show resolved Hide resolved
eng/common/scripts/Helpers/Resource-Helpers.ps1 Outdated Show resolved Hide resolved
eng/common/scripts/Helpers/Resource-Helpers.ps1 Outdated Show resolved Hide resolved
eng/common/scripts/Helpers/Resource-Helpers.ps1 Outdated Show resolved Hide resolved
- Fix rg.Name to rg.ResourceGroupName
- Add more verbose logging for better debugging
- Handle deleted resource groups when gathering puragable resource
- Remove coerce now that we are collecting in functions
@weshaggard
Copy link
Member Author

/azp run automation - live-test-resource-cleanup

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Aug 13, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@weshaggard weshaggard merged commit 58608fc into Azure:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants