Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install az module if not installed in deploy-stress-tests.ps1 #1995

Merged
1 commit merged into from
Sep 9, 2021
Merged

Install az module if not installed in deploy-stress-tests.ps1 #1995

1 commit merged into from
Sep 9, 2021

Conversation

benbp
Copy link
Member

@benbp benbp commented Sep 8, 2021

No description provided.

@benbp benbp requested a review from a team as a code owner September 8, 2021 21:42
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Sep 8, 2021
@benbp benbp self-assigned this Sep 8, 2021
@benbp benbp added Stress This issue is related to stress testing, part of our reliability pillar. pillar-reliability The issue is related to reliability, one of our core engineering pillars. (includes stress testing) labels Sep 8, 2021
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard
weshaggard reviewed Sep 8, 2021
View reviewed changes
eng/common/scripts/stress-testing/deploy-stress-tests.ps1
@@ -22,6 +22,7 @@ $FailedCommands = New-Object Collections.Generic.List[hashtable]

. (Join-Path $PSScriptRoot "../Helpers" PSModule-Helpers.ps1)
Install-ModuleIfNotInstalled "powershell-yaml" "0.4.1" | Import-Module
Install-ModuleIfNotInstalled "az" "6.4.0" | Import-Module
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually have a helper script just for this :) https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/scripts/Import-AzModules.ps1. However the script essentially does what you are doing here so I leave it to you how you want to use it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured just to be consistent with the other module install calls (and avoid double sourcing), I'd do it this way.

This was referenced Sep 9, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ghost
Copy link

ghost commented Sep 9, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit cc28d73 into Azure:main Sep 9, 2021
@benbp benbp deleted the benbp/stress-install-az branch September 10, 2021 19:37
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

Assignees

@benbp benbp

Labels
Central-EngSys This issue is owned by the Engineering System team. pillar-reliability The issue is related to reliability, one of our core engineering pillars. (includes stress testing) Stress This issue is related to stress testing, part of our reliability pillar.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbp @azure-sdk @weshaggard