Pass package name from calling pipeline to uniquely identify pull req… #2046
Conversation
praveenkuttappan
added
the
Central-EngSys
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
|
The following pipelines have been queued for testing: |
| @@ -30,14 +30,15 @@ public PullRequestController(PullRequestManager pullRequestManager, ILogger<Auto | |||
| string filePath, | |||
| int pullRequestNumber, | |||
| string commitSha, | |||
| string repoName) | |||
| string repoName, | |||
| string packageName) | |||
There was a problem hiding this comment.
This will work for most cases but something to consider for Java is that packageName is often artifactId and groupId. So when testing in Java we may hit a conflict but it should only ever happen if we mix track 1 and track 2 libraries but currently we only support track 2 so shouldn't be an issue. Just something to keep in the back of your mind.
Co-authored-by: Wes Haggard <[email protected]>
|
The following pipelines have been queued for testing: |
|
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
Currently file name is used to query API review document from cosmos DB within same PR. But .Net file path is different across each build due to generated version number for each build. This PR will submit a package name to API view to be used in query.