Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taking the parameter literally #2393

Merged
1 commit merged into from
Dec 8, 2021
Merged

Conversation

sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Dec 7, 2021

@sima-zhu sima-zhu requested a review from a team as a code owner December 7, 2021 18:45
@sima-zhu sima-zhu requested review from weshaggard and removed request for a team December 7, 2021 18:48
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@weshaggard
Copy link
Member

Why do you need to change the language repo's? If they don't need or use those parameters you shouldn't need to add them at all. Given you are passing them by name it will become a no-op for the language functions that don't define the parameters.

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Dec 8, 2021

@weshaggard Did not aware powershell is able to perform no-op when pass non-exist parameters. Testing in docindex which being affected and working as expected.
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1235635&view=results

@ghost
Copy link

ghost commented Dec 8, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 55b3bc0 into Azure:main Dec 8, 2021
@sima-zhu sima-zhu deleted the update_docms_packages branch December 8, 2021 05:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants