Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catch-all parameter to test resources script #2721

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

benbp
Copy link
Member

@benbp benbp commented Feb 8, 2022

This updates the New-TestResources.ps1 script to not fail when extra unused parameters are passed in. This prevents the script from breaking if new keys/values are added to the subscription config object in keyvault (which gets splatted onto the script parameters here). Currently this is a problem with historical versions of the script that get run as part of a backport to a hotfix/release branch, where the old version of the script is not compatible with the subscription configuration parameters.

For example, the addition of ProvisionerApplicationOid here is causing issues for live test pipeline runs using eng/common code older than the change as the parameter was also added to the subscription configuration.

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Feb 8, 2022
@benbp benbp self-assigned this Feb 8, 2022
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@ghost
Copy link

ghost commented Feb 9, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@benbp benbp merged commit 103da17 into Azure:main Feb 9, 2022
@benbp benbp deleted the benbp/test-resources-changelog branch February 9, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants