Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift APIView] Migrate from SwiftAST to SwiftSyntax #4789

Merged
merged 23 commits into from
Jan 13, 2023
Merged

[Swift APIView] Migrate from SwiftAST to SwiftSyntax #4789

merged 23 commits into from
Jan 13, 2023

Conversation

tjprescott
Copy link
Member

@tjprescott tjprescott commented Nov 23, 2022 •
edited
Loading

Fixes #3339.
Fixes #2527.
Fixes #2536.
Fixes #2541.
Fixes #3088.
Fixes #3089.
Fixes #4777.

Work remaining:

  • Ensure this works on an Obj-C-based framework like AzureCommunicationCalling
  • Remove all the cases that just use the default implementation.

@tjprescott tjprescott added APIView MQ This issue is part of a "milestone of quality" initiative. Swift labels Nov 23, 2022
@tjprescott tjprescott force-pushed the swift/swift-syntax branch 2 times, most recently from aa5efcf to 6609494 Compare December 15, 2022 17:02
@tjprescott tjprescott marked this pull request as ready for review December 30, 2022 21:46
@tjprescott
Copy link
Member Author

tjprescott commented Jan 4, 2023 •
edited
Loading

APIView for SwiftAPIViewTests
APIView for AzureCommunicationCalling

@tjprescott tjprescott requested a review from a team as a code owner January 5, 2023 17:10
mpodwysocki
mpodwysocki reviewed Jan 12, 2023
View reviewed changes
src/swift/SwiftAPIViewCore/Sources/Models/APIViewModel.swift Outdated
}
definitionIds.insert(defId)
return defId
}

/// Trime whitespace tokens
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling

mpodwysocki
mpodwysocki approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@mpodwysocki mpodwysocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjprescott tjprescott merged commit b4ae814 into main Jan 13, 2023
@tjprescott tjprescott deleted the swift/swift-syntax branch January 13, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpodwysocki mpodwysocki mpodwysocki approved these changes

Assignees

@tjprescott tjprescott

Labels
APIView MQ This issue is part of a "milestone of quality" initiative. Swift
Projects
ApiView
Status: ✅ Done
Milestone
No milestone
2 participants
@tjprescott @mpodwysocki