Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tests.CI.BuildTasks.csproj and Tests.CI.Common.csproj to net6.0 #4984

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

konrad-jamrozik
Copy link
Contributor

@konrad-jamrozik konrad-jamrozik commented Dec 15, 2022

This PR is a follow-up to:

it contributes to addressing:

Here I migrate some more projects from netcoreapp2.1 to net6.0.

I also quenched the error (escalated from warning):

MSB3270: There was a mismatch between the processor architecture of the project being built "MSIL" and the processor architecture of the reference (...) AMD64"

by forcing the relevant tests project to be win10-x64 too.

@konrad-jamrozik konrad-jamrozik self-assigned this Dec 15, 2022
@konrad-jamrozik konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Dec 15, 2022
Copy link
Contributor

@sima-zhu sima-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking quick action on this.

… of the project being built "MSIL" and the processor architecture of the reference (...) AMD64"

by forcing tests to be win10-x64 too.
@konrad-jamrozik konrad-jamrozik merged commit 1a79360 into main Dec 16, 2022
@konrad-jamrozik konrad-jamrozik deleted the users/kojamroz/update_mgmt_tools branch December 16, 2022 00:08
@konrad-jamrozik konrad-jamrozik changed the title Migrate Tests.CI.BuildTasks.csproj and Tests.CI.Common.csproj to net6.0 Update Tests.CI.BuildTasks.csproj and Tests.CI.Common.csproj to net6.0 Jan 9, 2023
@konrad-jamrozik konrad-jamrozik changed the title Update Tests.CI.BuildTasks.csproj and Tests.CI.Common.csproj to net6.0 Update Tests.CI.BuildTasks.csproj and Tests.CI.Common.csproj to net6.0 Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants