Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add continueOnError to create emitter-package-lock #8672

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add continueOnError to create emitter-package-lock #8672

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60780ba
Add continueOnError to create emitter-package-lock
Jul 22, 2024
113e308
update
Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion eng/pipelines/templates/stages/archetype-autorest-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ stages:
arguments: >
-EmitterPackageJsonPath "$(buildArtifactsPath)/emitter-package.json"
-OutputDirectory "$(Build.ArtifactStagingDirectory)"
continueOnError: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this cause us to potentially ignore real issues as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be, but I put the justification in the description that "we are now depending on @typespec/http-client-csharp which is in the TypeSpec repo" so that we cannot bump the version in @typespec/http-client-csharp. We currently don't have a way to fix the error here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue on error at least let the pipeline run. And the pipeline runs with reading dev version because we override it at the root, therefore the run result is reliable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hallipr can you help them solve this in another way? I would really like to avoid us blindly ignoring errors that is just going to lead to other issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also dislike ignoring the errors from npm list. We need to resolve the dependency issues to ensure we're testing the appropriate dependencies in the TypeSpec next runs.


- template: ../../../common/pipelines/templates/steps/publish-artifact.yml
parameters:
Expand Down Expand Up @@ -281,7 +282,9 @@ stages:
inputs:
pwsh: true
filePath: $(autorestRepositoryPath)/eng/scripts/Initialize-Repository.ps1
arguments: -BuildArtifactsPath '$(buildArtifactsPath)'
arguments: >
-BuildArtifactsPath '$(buildArtifactsPath)'
-UseTypeSpecNext:$${{ parameters.UseTypeSpecNext }}
workingDirectory: $(autorestRepositoryPath)

- task: PowerShell@2
Expand Down