Update TestProxy from Net6 to Net8 #9012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JimSuplizio
requested review from
scbedd,
mikeharder,
benbp and
a team
as code owners
JimSuplizio
added
the
Test-Proxy
scbedd
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Headers.Add used to exception if a duplicate was being added. Now it merely adds the value to the string array for the existing header.
This SHOULDN'T be a behavioral change that causes the target_version update to break anyone, but it's something to watch out for if you see weird test failures.
LMK when the eng/common prs are out, sdk-for-net has an additional change necessary to actually use the new proxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to update TestProxy by itself in its own PR but, unfortunately, Azure.Sdk.Tools.Assets.MaintenanceTool.sln has a dependency on TestProxy which required both projects to be updated.
I removed the conditional includes from the TestProxy since net5 is deader than disco. When upgrading the framework to Net8 I also updated Azure.Core and Microsoft.VisualStudio.Web.CodeGeneration.Design to their latest RTM versions.
using Microsoft.Build.Tasks;was removed because it no longer exists but was also a superfluous using.I also updated the version of Azure.Code and Azure.Storage.Blobs Azure.Sdk.Tools.TestProxy.StorageBlobSample.csproj to later versions which also did not require code changes.
@scbedd - I know once this is merged and published that I need to create another PR to update eng/common/testproxy/target_version.txt with that version.