-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change appropriate "preview" references to "beta" #1739
Conversation
Bookmarks and any reference to service preview versions were not changed.
I wasn't sure whether to change a script in there for Java, so I added a TODO. Should a doc or blurb be added as to why we decided to change? |
|
||
##### Incrementing after release (Python) | ||
|
||
**Preview Release:** `1.0.0b1` -> `1.0.0b2` | ||
**Beta Release:** `1.0.0b1` -> `1.0.0b2` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heaths I'm torn about changing this language. It is still a preview release we just happen to use "beta" for the prerelease tag. Do you think it is better to call these beta releases?
On a similar note I'm going to be changing the tags for "dev" builds to use "alpha" for the prerelease tag but I plan to still refer to them as daily dev releases as opposed to alpha releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you're point, but worry that would be confusing (calling it "beta" some places and "preview" others), and could be cause for alarm as to why we are making this change in the first place. Seems better to scrub "preview" in as many places as possible. I just made sure to leave any references to service previews as-is (weren't many).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated my PR to refer to it as beta release anywhere we were talking about our libraries, and kept the work preview when referring to the service version.
@@ -103,6 +103,7 @@ function Update-java-Packages($packageList) | |||
Write-Warning "Not updating VersionGA for $($pkg.Package) because at least one associated URL is not valid!" | |||
} | |||
|
|||
# TODO: Do references to "latest-preview" need to be changed to "latest-beta"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one requires more work elsewhere before we can change. It is tied to the docs and they still refer to things as preview so I'm not likely going to change that.
Closing in favor of #1536. I believe I have captured everything you have here in my PR but please let me know if I missed something. |
Bookmarks and any reference to service preview versions were not changed.