Fix log file path (#2478)

Azure · Dec 4, 2023 · 11596f8 · 11596f8
1 parent 3feeb6e
commit 11596f8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/common/lifecyleMgr.go b/common/lifecyleMgr.go
@@ -372,6 +372,7 @@ func (lcm *lifecycleMgr) Exit(o OutputBuilder, applicationExitCode ExitCode) {
 		exitCode:   applicationExitCode,
 	}
 
+	AzcopyCurrentJobLogger.CloseLog()
 	if applicationExitCode != EExitCode.NoExit() {
 		// stall forever until the success message is printed and program exits
 		lcm.SurrenderControl()

diff --git a/common/rotatingWriter.go b/common/rotatingWriter.go
@@ -88,7 +88,13 @@ func (w *rotatingWriter) rotate(suffix int32) error {
 }
 
 func (w *rotatingWriter) Close() error {
-	return w.file.Close()
+	if err := w.file.Close(); err != nil {
+		return err
+	}
+	if err := os.Rename(w.filePath, w.filePath + ".log"); err != nil {
+		return err
+	}
+	return nil
 }
 
 func (w *rotatingWriter) Write(p []byte) (n int, err error) {

diff --git a/common/rotatingWriter_test.go b/common/rotatingWriter_test.go
@@ -112,7 +112,7 @@ func TestRotatingWriter(t *testing.T) {
 	a.Nil(err)
 	a.Equal(3, len(entries))
 	f = convertToMap(entries)
-	a.Contains(f, logFileName)
+	a.Contains(f, logFileName + ".log")
 	a.Contains(f, logFileName + ".0.log")
 	a.Contains(f, logFileName + ".1.log")
 }