Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added location flag to list command to specify location for non standard URLs #2595

Merged
merged 25 commits into from
Apr 24, 2024

Conversation

gapra-msft
Copy link
Member

@gapra-msft gapra-msft commented Feb 28, 2024

Resolves #1090

@gapra-msft gapra-msft changed the title Gapra/list argument Added location flag to list command to specify location for non standard URLs Feb 28, 2024
Base automatically changed from gapra/listJson to main April 5, 2024 17:51
Copy link
Member

@adreed-msft adreed-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, seems pretty clean. I assume tests are coming in the future list testing PR?

@gapra-msft
Copy link
Member Author

lgtm, seems pretty clean. I assume tests are coming in the future list testing PR?

For this particular change, I focused on unit testing the InferArgumentLocation method in validators_test.go

I can look into adding a e2e test, we would need to enable private endpoint in the account.

@gapra-msft gapra-msft merged commit a980355 into main Apr 24, 2024
17 checks passed
@gapra-msft gapra-msft deleted the gapra/listArgument branch April 24, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AzCopy copy vs list location inference break
3 participants