-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AzCopy panics when uploading 16.5 TB disk snapshot to a container in blob storage #2635
Merged
siminsavani-msft
merged 14 commits into
main
from
siminsavani/azcopy-panic-managed-disk
May 10, 2024
Merged
AzCopy panics when uploading 16.5 TB disk snapshot to a container in blob storage #2635
siminsavani-msft
merged 14 commits into
main
from
siminsavani/azcopy-panic-managed-disk
May 10, 2024
+206
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
siminsavani-msft
commented
Apr 3, 2024
•
edited
Loading
edited
- Retrieve LMT through a helper method that handles if LMT is nil or not
- Retrieve ContentLength through a helper method that handles if ContentLength is nil or not
- E2E tests written to test locally and avoid lengthy testing time in CI due to large size of managed disk snapshot (7.9 TB). Must be set up locally.
- Unit tests that mocks service GetProperties response
- Resolves azcopy copy memory error on 10.23.0 MacOS via brew using SAS #2606
gapra-msft
reviewed
Apr 3, 2024
gapra-msft
reviewed
Apr 3, 2024
gapra-msft
reviewed
Apr 3, 2024
adreed-msft
requested changes
Apr 3, 2024
gapra-msft
reviewed
Apr 3, 2024
siminsavani-msft
requested review from
nakulkar-msft,
vibhansa-msft,
seanmcc-msft and
pranavmalik-msft
as code owners
April 17, 2024 17:25
gapra-msft
reviewed
Apr 17, 2024
gapra-msft
reviewed
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left comments
|
adreed-msft
approved these changes
Apr 22, 2024
adreed-msft
approved these changes
Apr 24, 2024
gapra-msft
reviewed
Apr 25, 2024
gapra-msft
reviewed
May 10, 2024
gapra-msft
approved these changes
May 10, 2024
gapra-msft
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.