Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a public set_storage_credentials method in cloud_client #303

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

scharan
Copy link

@scharan scharan commented Nov 5, 2019

This is useful/needed to swap between primary and secondary shared access keys without recreating the client, in conjunction with retries and retry handling in azure::storage::operation_context::set_response_received.

This is useful/needed to swap between primary and secondary shared access keys without recreating the client, in conjunction with retries and retry handling in azure::storage::operation_context::set_response_received.
@katmsft
Copy link
Member

katmsft commented Nov 6, 2019

Hi, thanks for the contribution!
Can you elaborate the user scenario needed to swap between keys when retrying?
Also, this change will make the cloud_client loose thread-safety. If it the use case can be justified, the PR still needs to be modified so that the cloud_client is thread safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants