-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3.9 Support #174
Python3.9 Support #174
Conversation
The following issue is with cython==0.28.5: python 3.9 has removed note |
@yunhaoling this is absolutely the same issue I saw with my pr. Overall, this is a really nice addition, the support just isn't there. |
windows building fails with latest cython 0.29.21 (and 3.0a6)
|
This has definitely been fixed in Cython - I suspect your build script is not regenerating the file correctly. |
thanks Steve @zooba , it's indeed my fault that I didn't clean up previously-built files leading to the compile failure. |
5a71238
to
654c094
Compare
post-release issue: #178
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks! :)
|
||
installer_folder = os.path.normpath(os.path.abspath(installer_folder)) | ||
if not os.path.exists(installer_folder): | ||
os.mkdir(installer_folder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to handle any permissions issues on the installation directory? Or just let them raise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the answer, the scripts are provided by Scott. (to be more precise, scripts are here in our mono repo: Azure/azure-sdk-for-python#14160)
but I think he should have already taken it into account :P cc @scbedd
No description provided.