Fix default operation name on ServiceBus requests #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brettsam please review |
brettsam
reviewed
Oct 10, 2018
...Jobs.Host.EndToEndTests/ApplicationInsights/ServiceBusRequestAndDependencyCollectionTests.cs
Outdated
Show resolved
Hide resolved
...rosoft.Azure.WebJobs.Logging.ApplicationInsights/Initializers/WebJobsTelemetryInitializer.cs
Show resolved
Hide resolved
|
FYI -- this will address Azure/azure-functions-host#3585. |
|
@brettsam thanks for the review! please merge |
brettsam
approved these changes
Oct 10, 2018
lmolkova
force-pushed
the
lmolkova/filServiceBusOperationName
branch
from
8ecc9bd
to
4dce071
Compare
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of microsoft/ApplicationInsights-dotnet-server#1038 some ServiceBus requests do not have operation name set to function name.
This happens because AppInsights stops the Activity prematurely. It will be fixed in the next ApplicationInsights SDK release.
This change provides workaround for this issue. It could be safely removed with update of AI SDK.