Fix name collision in indexer cache (#2645) #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathewc
commented
Feb 2, 2021
| @@ -34,7 +34,12 @@ public void Add(IFunctionDefinition function, FunctionDescriptor descriptor, Met | |||
| _functionsByMethod.Add(method, function); | |||
|
|
|||
| // For compat, accept either the short name ("Class.Name") or log name (just "Name") | |||
| _functionsByName.Add(descriptor.LogName, function); | |||
| if (!_functionsByName.ContainsKey(descriptor.LogName)) | |||
There was a problem hiding this comment.
This fix retains the previous logic of first one wins that existed before cache was added. See previous logic here.
fabiocav
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2645. As noted in the issue, the bug was introduced in 76d44ca when a method name cache was introduced.