Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix aad url #1024

Merged
merged 1 commit into from
Jul 12, 2023
Merged

docs: fix aad url #1024

merged 1 commit into from
Jul 12, 2023

Conversation

aramase
Copy link
Member

@aramase aramase commented Jul 12, 2023

➜ curl -s -o /dev/null -w "%{http_code}" https://azure.microsoft.com/en-us/services/active-directory/
301

➜ curl -s -o /dev/null -w "%{http_code}" https://azure.microsoft.com/en-us/products/active-directory/
200

fixes markdown link failure: https://github.com/Azure/azure-workload-identity/actions/runs/5381004949/jobs/9764511553

https://azure.microsoft.com/ seems to be failing here. This might be because of some change in the direct behavior, so temporarily disabling the check for that URL.

@aramase aramase requested a review from enj as a code owner July 12, 2023 17:29
@aramase aramase requested a review from sozercan July 12, 2023 17:29
@aramase aramase enabled auto-merge (squash) July 12, 2023 17:30
@codecov-commenter
Copy link

Codecov Report

Merging #1024 (6cf5f48) into main (a5fc57d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1024   +/-   ##
=======================================
  Coverage   53.71%   53.71%           
=======================================
  Files          36       36           
  Lines        2290     2290           
=======================================
  Hits         1230     1230           
  Misses       1014     1014           
  Partials       46       46           

@aramase aramase disabled auto-merge July 12, 2023 17:37
@aramase aramase marked this pull request as draft July 12, 2023 17:37
Signed-off-by: Anish Ramasekar <[email protected]>
@aramase aramase marked this pull request as ready for review July 12, 2023 21:37
@aramase aramase merged commit 215911a into Azure:main Jul 12, 2023
@aramase aramase deleted the aramase/d/update_aad_url branch July 12, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants