Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add tenant id reference in quick start #105

Merged
merged 1 commit into from
Jul 27, 2021
Merged

docs: add tenant id reference in quick start #105

merged 1 commit into from
Jul 27, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Jul 26, 2021

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • Updates the export SERVICE_PRINCIPAL_CLIENT_ID to use the output from az ad sp create.
  • Adds reference to tenant id annotation if the keyvault instance and SP are in different tenant.

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:

@aramase aramase requested a review from chewong July 26, 2021 23:51
@aramase aramase enabled auto-merge (squash) July 27, 2021 00:17
@aramase aramase merged commit aec36b4 into Azure:main Jul 27, 2021
@aramase aramase deleted the update-doc branch July 27, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chewong chewong chewong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aramase @chewong