Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update website deploy workflow #111

Merged
merged 1 commit into from
Jul 28, 2021
Merged

chore: update website deploy workflow #111

merged 1 commit into from
Jul 28, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Jul 28, 2021

Signed-off-by: Anish Ramasekar [email protected]

Reason for Change:

  • Renames website deploy workflow and updated the triggers
  • Changes destination dir to ./website as gh-pages will also be used for helm charts

Requirements

  • squashed commits
  • included documentation
  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Please answer the following questions with yes/no:

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

  • yes
  • no

Notes for Reviewers:
This yaml file has been updated referencing https://github.com/open-policy-agent/gatekeeper/blob/master/.github/workflows/website.yaml

@aramase aramase requested a review from chewong July 28, 2021 17:55
@aramase aramase merged commit 8ff213c into Azure:main Jul 28, 2021
@aramase aramase deleted the website-action branch July 28, 2021 18:34
@chewong
Copy link
Contributor

chewong commented Jul 28, 2021

We might have to revert this because it looks like gh-pages only supports deploying website from root or from the docs folder. There is no option to deploy the website from the website folder. (https://github.com/Azure/aad-pod-managed-identity/settings/pages)

@aramase
Copy link
Member Author

aramase commented Jul 28, 2021

We might have to revert this because it looks like gh-pages only supports deploying website from root or from the docs folder. There is no option to deploy the website from the website folder. (https://github.com/Azure/aad-pod-managed-identity/settings/pages)

We can change it to docs instead of website if that's what it supports.

@chewong
Copy link
Contributor

chewong commented Jul 28, 2021

Sounds good

@aramase aramase mentioned this pull request Jul 28, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants