Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for arc clusters #25

Merged
merged 1 commit into from
May 12, 2021
Merged

feat: add support for arc clusters #25

merged 1 commit into from
May 12, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented May 11, 2021

Signed-off-by: Anish Ramasekar [email protected]

  • Added a new flag --arc-cluster which can be used for configuring webhook in arc clusters.
  • Removed dependency on azure.json, so it's easier to deploy and run the webhook on any non-azure cluster.

The config is obtained from a configmap

kubectl create configmap aad-pi-config --from-literal=AZURE_TENANT_ID=${AZURE_TENANT_ID} --namespace=aad-pi-webhook-system

fixes #16

pkg/config/config.go Outdated Show resolved Hide resolved
scripts/ci-e2e.sh Show resolved Hide resolved
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
pkg/webhook/webhook.go Outdated Show resolved Hide resolved
@chewong
Copy link
Contributor

chewong commented May 12, 2021

Opened #27 to track e2e test status

Signed-off-by: Anish Ramasekar <[email protected]>
@aramase aramase merged commit d857e00 into Azure:main May 12, 2021
@aramase aramase deleted the arc branch May 12, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for arc clusters
2 participants